Remove platform version complexity for Java version #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OpenVox only supports platform 7 and 8, and we don't really need to worry about ancient el8 being weird. We build OpenVox with Java 11, so make this the base version, and ideally use 17 when available.
ekohl
reviewed
Feb 20, 2025
| @@ -189,24 +189,13 @@ | |||
| options.systemd_el = 1 | |||
| elsif options.operating_system == :el && options.os_version >= 7 # systemd el | |||
There was a problem hiding this comment.
Do we even build for EL6 or can we also simplify this?
This was referenced Feb 20, 2025
ekohl
reviewed
Feb 20, 2025
| 'java-11-openjdk-headless' | ||
| elsif options.os_version >= 8 | ||
| 'java-17-openjdk-headless' | ||
| else |
There was a problem hiding this comment.
Even this else is not needed since line 190 already guarantees os_version is at least 7. I'll clean that up in a later patch.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OpenVox only supports platform 7 and 8, and we don't really need to worry about ancient el8 being weird. We build OpenVox with Java 11, so make this the base version, and ideally use 17 when available.