Skip to content

Commit

Permalink
Merge pull request #6 from OpenVoxProject/remove_java_platform_comple…
Browse files Browse the repository at this point in the history
…xity

Remove platform version complexity for Java version
  • Loading branch information
nmburgan authored Feb 20, 2025
2 parents 07cb326 + 2eb83b3 commit 6937a73
Show file tree
Hide file tree
Showing 3 changed files with 7 additions and 29 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/pr.yml
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ jobs:
runs-on: ubuntu-latest
strategy:
matrix:
java: [ '8', '11' ]
java: [ '11, '17' ]
env:
LEIN_HOME: local

Expand Down
33 changes: 5 additions & 28 deletions resources/puppetlabs/lein-ezbake/template/global/ext/fpm.rb
Original file line number Diff line number Diff line change
Expand Up @@ -189,24 +189,13 @@
options.systemd_el = 1
elsif options.operating_system == :el && options.os_version >= 7 # systemd el
if ! options.is_pe
fpm_opts << "--depends tzdata-java"
options.java =
case options.platform_version
when 8
# rpm on Redhat 7 may not support OR dependencies
if options.os_version == 7
'java-11-openjdk-headless'
elsif options.os_version == 8
'(java-17-openjdk-headless or java-11-openjdk-headless)'
elsif options.os_version >= 9
'java-17-openjdk-headless'
else
fail "Unrecognized el os version #{options.os_version}"
end
when 7
if options.os_version == 7
'java-11-openjdk-headless'
elsif options.os_version >= 8
'java-17-openjdk-headless'
else
fail "Unknown Puppet Platform Version #{options.platform_version}"
fail "Unrecognized el os version #{options.os_version}"
end
end

Expand All @@ -223,19 +212,7 @@
options.systemd_sles = 1
options.sles = 1
if ! options.is_pe
options.java =
case options.platform_version
when 8
'java-11-openjdk-headless'
when 7
if options.os_version > 12
'java-11-openjdk-headless'
else
'java-1_8_0-openjdk-headless'
end
else
fail "Unknown Puppet Platform Version #{options.platform_version}"
end
options.java = 'java-11-openjdk-headless'
end
elsif options.operating_system == :sles #old sles
options.sysvinit = 1
Expand Down
1 change: 1 addition & 0 deletions test/unit/puppetlabs/ezbake/core_test.clj
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,7 @@
:is-pe-build "false"
:reload-timeout "'120'"
:bootstrap-source "'bootstrap-cfg'"
:package-name "'dummy'"
:debian-interested-install-triggers ()
:group "'dummy'"
:java-args "'-Xmx192m'"
Expand Down

0 comments on commit 6937a73

Please sign in to comment.