Ensure workflow is triggered on pull request updates #31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ensure `synchronize` event also trigger the workflow, as relying solely on push events failed for pull requests from forked repositories. See https://docs.github.com/en/actions/using-workflows/events-that-trigger-workflows#pull_request
Push triggers outside of pull requests are omitted intentionally to prevent duplicate workflow runs. Since this repository mainly involves managing service declarations rather than altering software features, running tests on every commit of every branch isn't seen as essential compared to traditional software.
MattiSG
approved these changes
Feb 6, 2024
clementbiron
approved these changes
Feb 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks to @Kissaki for spotting the issue in #30. As a result, this PR ensures that the test workflow triggers on every pull request update.