Fix GraphCMS/Hygraph Privacy Policy and Terms of Service

[Kissaki]

• Rename GraphCMS to Hygraph as per branding change
• Fix Hygraph Privacy Policy and Terms of Service with new URL and selector

See commit descriptions for details.

Replaces my PR #1146, Fixes #1073, #1074

[Kissaki]

Uncaught Error: The "Hygraph.history" service declaration is malformed and cannot be parsed

What is malformed? I don't see it.

I don't have a local nodejs env and don't want to install one.

[clementbiron]

Hi Kissaki, thanks for your contribution :)

The GraphCMS.json should not be deleted, it should be empty, see the renaming a service documentation.

{
  "name": "GraphCMS",
  "documents": {}
}

[Kissaki]

@clementbiron if you look at the commits in this PR you can see it is not being deleted. The guidance did not exist yet when I originally created this PR; but on December 2nd I force-pushed, presumably with the adjustment to the new guidance - not deleting the file.

I can see the overall diff in GitHub UI "Files Changed" still showing it as being deleted though.

Maybe this is related to force-pushes also not triggering CI too? Does this repository have a configuration that prevents PR updates through force-pushes somehow? Is it a general GitHub issue? (I am used to force-pushes in GitLab updating MR commit list and overall diff - and the overall diff with a new diff version.)

[Kissaki]

I tried a few force pushes, main branch merge, etc, but nothing changed what GitHub displays

[Kissaki]

It's a GitHub Actions configuration issue. My suggested fix: OpenTermsArchive/demo-declarations#30

[clementbiron]

Hello,

I'm sorry, I probably didn't make myself clear in my previous review.

You have renamed the GraphCMS.json file to Hygraph.json and this is not the right thing to do. The GraphCMS.json file must continue to be present but it must be emptied of all terms by removing every <terms type> entries from the documents key in the declaration. A new Hygraph.json file is added and completed to track the documents of the renamed service.

We should therefore have the GraphCMS.json, GraphCMS.history.json and Hygraph.json files.

Regarding your problem with launching tests on the CI, we have merged a pull request based on your proposal, which we think is an acceptable compromise. Thank you very much for reporting the problem and suggesting a solution 🙏

[Kissaki]

I fixed it according to the renaming guidance.

[clementbiron]

Thank you very much! 🚀