Idle handlers no longer defer to scene-graph parents. #1001
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Parents still wait for all children to be idle. Before, if a map had multiple layers, for instance, `oneLayer.onIdle` would wait for all layers and the map to be idle before triggering. Now, `oneLayer.onIdle` will only wait for that layer and its children. `mainMap.onIdle` will wait for all of the layers and their children as before. This is useful, for instance, if you have two tile layers and you wish to trigger a function when one of the tile layers is fully loaded without waiting for the second tile layer. You can still wait for both by using `map.onIdle`.
aashish24
approved these changes
Jun 10, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Parents still wait for all children to be idle.
Before, if a map had multiple layers, for instance,
oneLayer.onIdlewould wait for all layers and the map to be idle before triggering. Now,oneLayer.onIdlewill only wait for that layer and its children.mainMap.onIdlewill wait for all of the layers and their children as before.This is useful, for instance, if you have two tile layers and you wish to trigger a function when one of the tile layers is fully loaded without waiting for the second tile layer. You can still wait for both by using
map.onIdle.