Subcodes

[RalphBln]

No description provided.

[ChristophB]

Open tasks in addition to my comments:

• upgrade top-api
• add tests

[ChristophB]

Please also update the enum test at src/test/java/care/smith/top/backend/EnumTest.java when adding new enums.

assertThat(CodeScope.values())
    .isEqualTo(
        new CodeScope[] {
            CodeScope.SELF,
            CodeScope.SUBTREE,
            CodeScope.LEAVES
        });

[ChristophB]

Increased version to 0.8.0

[ChristophB]

Some open issues

1. Code system URIs are derived from ontology.getConfig().getId(), which doesn't seem right. If I connect to https://www.ebi.ac.uk/ols4, SNOMEDCT has the ID "snomed".
   Should ontology.getConfig().getVersionIri() be used, if available?

2. Child nodes don't have a short name for their code system

[RalphBln]

1. Code system URIs are derived from ontology.getConfig().getId(), which doesn't seem right. If I connect to https://www.ebi.ac.uk/ols4, SNOMEDCT has the ID "snomed".

While the public EBI OLS instance uses abbreviated labels as ontology ids, our import mechanism makes sure that ontologies being loaded into our TOP OLS instances always have their ontology IRI set as their OLS id.

"id": "http://snomed.info/sct",
"versionIri": null,

Should ontology.getConfig().getVersionIri() be used, if available?

I agree as it might be useful in the context of code versioning. Added in dfa6dab.

[ChristophB]

@RalphBln, what is the status on:

Child nodes don't have a short name for their code system

[RalphBln]

@RalphBln, what is the status on:

Child nodes don't have a short name for their code system

Addressed in 6ea4864.

[ChristophB]

Is there anything missing or is this PR ready to be merged?