Fix for large terminologies in concept search #236
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…de only once and all entities are stored in a map. every subsequent request for an entity is made on this map
…e call (gathering of sub dependencies) is done in the DB directly
…de only once and all entities are stored in a map. every subsequent request for an entity is made on this map
…e call (gathering of sub dependencies) is done in the DB directly
…ept-search' into fix-for-large-terminologies-concept-search
ChristophB
requested changes
Jan 30, 2025
There was a problem hiding this comment.
I can't accept this PR, because it contains commits from #218. Please remove them.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR solves the problem that queries slowed down due to a disadvantageous implementation of a recursive call to the DB when gathering all entities for a query. The recursion is now done with a custom SQL query.
Secondly, a max term count check was introduced that rejects queries which terms surpass a specific value (slightly experimentally deduced but anecdotal value of 15.000 at the moment).