Python sample creation #1478
Merged
Python sample creation #1478
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Copilot reviewed 73 out of 88 changed files in this pull request and generated 2 comments.
Files not reviewed (15)
- samples/bot-adaptive-card-actions/python/.gitignore: Language not supported
- samples/bot-adaptive-card-actions/python/.vscode/extensions.json: Language not supported
- samples/bot-adaptive-card-actions/python/.vscode/launch.json: Language not supported
- samples/bot-adaptive-card-actions/python/.vscode/settings.json: Language not supported
- samples/bot-adaptive-card-actions/python/.vscode/tasks.json: Language not supported
- samples/bot-adaptive-card-actions/python/appManifest/manifest.json: Language not supported
- samples/bot-adaptive-card-actions/python/assets/sample.json: Language not supported
- samples/bot-adaptive-card-actions/python/env/.env.local: Language not supported
- samples/bot-adaptive-card-actions/python/infra/azure.bicep: Language not supported
- samples/bot-adaptive-card-actions/python/infra/azure.parameters.json: Language not supported
- samples/bot-adaptive-card-actions/python/requirements.txt: Language not supported
- samples/bot-commands-menu/python/.gitignore: Language not supported
- samples/bot-commands-menu/python/.vscode/extensions.json: Language not supported
- samples/bot-adaptive-card-actions/python/teamsapp.yml: Evaluated as low risk
- samples/bot-adaptive-card-actions/python/bots/init.py: Evaluated as low risk
Comments suppressed due to low confidence (5)
samples/bot-adaptive-card-actions/python/app.py:42
- [nitpick] The error message could be more informative. Consider suggesting checking the logs for more details.
To continue to run this bot, please fix the bot source code.
samples/bot-adaptive-card-actions/python/config.py:14
- [nitpick] The placeholder value "<>" is ambiguous. It should be renamed to "YOUR_MICROSOFT_APP_ID" to make it clear that this value needs to be replaced with an actual environment variable.
APP_ID = os.environ.get("MicrosoftAppId", "<<MICROSOFT-APP-ID>>")
samples/bot-adaptive-card-actions/python/config.py:15
- [nitpick] The placeholder value "<>" is ambiguous. It should be renamed to "YOUR_MICROSOFT_APP_PASSWORD" to make it clear that this value needs to be replaced with an actual environment variable.
APP_PASSWORD = os.environ.get("MicrosoftAppPassword", "<<MICROSOFT-APP-PASSWORD>>")
samples/bot-adaptive-card-actions/python/bots/adaptive_card_actions_bot.py:45
- Correct the typo in the message: 'Toggle Visible Card' should be 'ToggleVisibility Card' to match the command.
"**2** for Bot Suggested Actions, and **3** for Toggle Visible Card."
samples/bot-adaptive-card-actions/python/bots/adaptive_card_actions_bot.py:91
- [nitpick] The error message could be more descriptive, such as 'Please enter your name.'
"errorMessage": "Name is required"
samples/bot-adaptive-card-actions/python/bots/adaptive_card_actions_bot.py
Show resolved
Hide resolved
There was a problem hiding this comment.
Copilot reviewed 73 out of 88 changed files in this pull request and generated no comments.
Files not reviewed (15)
- samples/bot-adaptive-card-actions/python/.gitignore: Language not supported
- samples/bot-adaptive-card-actions/python/.vscode/extensions.json: Language not supported
- samples/bot-adaptive-card-actions/python/.vscode/launch.json: Language not supported
- samples/bot-adaptive-card-actions/python/.vscode/settings.json: Language not supported
- samples/bot-adaptive-card-actions/python/.vscode/tasks.json: Language not supported
- samples/bot-adaptive-card-actions/python/appManifest/manifest.json: Language not supported
- samples/bot-adaptive-card-actions/python/assets/sample.json: Language not supported
- samples/bot-adaptive-card-actions/python/env/.env.local: Language not supported
- samples/bot-adaptive-card-actions/python/infra/azure.bicep: Language not supported
- samples/bot-adaptive-card-actions/python/infra/azure.parameters.json: Language not supported
- samples/bot-adaptive-card-actions/python/requirements.txt: Language not supported
- samples/bot-commands-menu/python/.gitignore: Language not supported
- samples/bot-commands-menu/python/.vscode/extensions.json: Language not supported
- samples/bot-adaptive-card-actions/python/bots/init.py: Evaluated as low risk
- samples/bot-adaptive-card-actions/python/bots/adaptive_card_actions_bot.py: Evaluated as low risk
Harikrishnan-MSFT
approved these changes
Jan 7, 2025
Pawank-MSFT
approved these changes
Jan 7, 2025
|
Executed Build pipeline https://github.com/OfficeDev/Microsoft-Teams-Samples/actions/runs/12646083551 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.