[17.0][MIG] mail_forward: Migration to version 17.0 #1536
Conversation
|
/ocabot migration mail_forward |
|
This PR has the |
|
/ocabot merge nobump |
|
Hey, thanks for contributing! Proceeding to merge this for you. |
|
@pedrobaeza your merge command was aborted due to failed check(s), which you can inspect on this commit of 17.0-ocabot-merge-pr-1536-by-pedrobaeza-bump-nobump. After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red. |
|
/ocabot merge nobump |
|
On my way to merge this fine PR! |
|
@pedrobaeza your merge command was aborted due to failed check(s), which you can inspect on this commit of 17.0-ocabot-merge-pr-1536-by-pedrobaeza-bump-nobump. After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red. |
|
@carlos-lopez-tecnativa can you check the error is now in |
carlos-lopez-tecnativa
force-pushed
the
17.0-mig-mail_forward
branch
from
203422d to
a34b547
Compare
@pedrobaeza I believe this issue stems from an Odoo bug. For more details, please refer to the commit message: |
|
I can't say. If you are sure that it's the way to go... Can't be patched here in OCA? @chienandalu may suggest something as well. |
carlos-lopez-tecnativa
force-pushed
the
17.0-mig-mail_forward
branch
from
a34b547 to
edfbe03
Compare
|
Is this mergeable then? |
| https://github.com/odoo/odoo/blob/a32626be4cfbaeb21ed64a0abaad298e8e223ea3/addons/mail/static/src/core/common/message.xml#L146-L160 --> | ||
| <xpath expr="//DropdownItem//i" position="before"> | ||
| <t | ||
| t-if="action.callComponent" |
There was a problem hiding this comment.
Maybe I'd add a flag in the action to constrain the behavior to this module.
There was a problem hiding this comment.
@chienandalu I tried to add a flag, but it is not possible. The reason is that the action definition is done by adding a new action to messageActionsRegistry:
https://github.com/odoo/odoo/blob/afa014502259eb82ef03eb2d681b606665e85b42/addons/mail/static/src/core/common/message_actions.js#L14
However, this definition is transformed to be passed as XML in the function transformAction, and this function is not exportable, so I cannot inherit it to add a new flag:
https://github.com/odoo/odoo/blob/afa014502259eb82ef03eb2d681b606665e85b42/addons/mail/static/src/core/common/message_actions.js#L104
Please let me know if you have other suggestions or if we can continue with the merge.
@pedrobaeza I created the PR to Odoo. If this PR is merged, the last change can be reverted. But to avoid waiting, I think this PR is ready to merge.
There was a problem hiding this comment.
Please put here then the TODO that this should be removed or changed to whatever if the PR link is merged.
There was a problem hiding this comment.
@pedrobaeza Done. I split the commit to keep this change in a specific commit, which can be reverted if necessary. Please let me know if this works for you. Thanks in advance.
Currently, Odoo only renders the callComponent for quick actions (2 or 3 actions). However, the remaining actions, rendered as DropdownItem, do not invoke the callComponent.
This commit ensures that the rendering is consistent in both cases.
Complementary to: #131426
TODO: This code should be removed once the issue is fixed in the Odoo core.
odoo/odoo#194643
carlos-lopez-tecnativa
force-pushed
the
17.0-mig-mail_forward
branch
from
edfbe03 to
ea11305
Compare
|
/ocabot merge nobump |
|
On my way to merge this fine PR! |
|
Congratulations, your PR was merged at ac71ee9. Thanks a lot for contributing to OCA. ❤️ |
TT51933
@Tecnativa @pedrobaeza @chienandalu could you please review this