[FW][17.0][FIX] mail: Render message actions correctly with callComponent #195183
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, Odoo only renders the callComponent for quick actions (2 or 3 actions). However, the remaining actions, rendered as DropdownItem, do not invoke the callComponent. This commit ensures that the rendering is consistent in both cases. Complementary to: odoo#131426 X-original-commit: 86ec467
|
|
|
This PR targets saas-17.4 and is part of the forward-port chain. Further PRs will be created up to master. More info at https://github.com/odoo/odoo/wiki/Mergebot#forward-port |
|
@celm1990 @alexkuhn the next pull request (#195185) is in conflict. You can merge the chain up to here by saying
More info at https://github.com/odoo/odoo/wiki/Mergebot#forward-port |
|
@robodoo r+ |
robodoo
pushed a commit
that referenced
this pull request
Jan 25, 2025
Currently, Odoo only renders the callComponent for quick actions (2 or 3 actions). However, the remaining actions, rendered as DropdownItem, do not invoke the callComponent. This commit ensures that the rendering is consistent in both cases. Complementary to: #131426 closes #195183 X-original-commit: 86ec467 Signed-off-by: Alexandre Kühn (aku) <[email protected]>
alexkuhn
deleted the
saas-17.4-17.0-mail-render-messageActions-with-callComponent-2jhf-fw
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the issue/feature this PR addresses:
When a custom module (e.g., OCA/social#1536) adds a new message action using
callComponent, it is not invoked in certain scenarios.Current behavior before PR:
Odoo only invokes
callComponentforquick actions(2 or 3 actions). For remaining actions rendered asDropdownItem, thecallComponentis not invoked.Desired behavior after PR is merged:
This commit ensures consistent rendering behavior, invoking the
callComponentfor all actions, whether quick actions or dropdown items.Complementary to: #131426
@phenix-factory @alexkuhn coud you please review this?
CC @pedrobaeza @chienandalu
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
Forward-Port-Of: #194751
Forward-Port-Of: #194643