Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: remove isomorphic-git dependency in favor of local git command #386

Merged
merged 1 commit into from
Jul 15, 2024

Conversation

ErwanRaulo
Copy link
Contributor

  • remove isomorphic-git dependency
  • execute installed git binary to clone a repository
  • format URL to handle access token

@ErwanRaulo
Copy link
Contributor Author

i'm not sure about how i insert token in URL.
I've forgot to put issue number in commit message.

@PierreDemailly PierreDemailly linked an issue Jul 15, 2024 that may be closed by this pull request
@PierreDemailly
Copy link
Member

I've forgot to put issue number in commit message.

We conventionally never put issue number in commit message so it's fine 👍 If you want to link the PR to the issue, see Linking a pull request to an issue using a keyword

@fraxken fraxken merged commit 70a3ea7 into NodeSecure:master Jul 15, 2024
3 checks passed
@fraxken
Copy link
Member

fraxken commented Jul 15, 2024

@allcontributors please add @orlando1108 for code

Copy link
Contributor

@fraxken

I've put up a pull request to add @orlando1108! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove isomorphic-git dependency and use a Child proc
3 participants