Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove isomorphic-git dependency and use a Child proc #367

Closed
fraxken opened this issue Jul 1, 2024 · 4 comments · Fixed by #386
Closed

Remove isomorphic-git dependency and use a Child proc #367

fraxken opened this issue Jul 1, 2024 · 4 comments · Fixed by #386
Assignees
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@fraxken
Copy link
Member

fraxken commented Jul 1, 2024

We introduce isomorphic-git just for running a git clone command (that's quite a lot of packages). We probably need to replace that with a simple child proc instead

@fraxken fraxken added enhancement New feature or request good first issue Good for newcomers labels Jul 1, 2024
@PierreDemailly
Copy link
Member

I think we can use scanner.from instead of clone + scanner.cwd
Wdyt @fraxken ? Am i missing something ?

@fraxken
Copy link
Member Author

fraxken commented Jul 3, 2024

@PierreDemailly No because from require that the spec exist in the registry. The goal is to clone and analyze git projects with no relation to the registry.

@fraxken
Copy link
Member Author

fraxken commented Jul 3, 2024

Or I'm missing something myself lol

@ErwanRaulo
Copy link
Contributor

Hi, can you asssign me on that issue please?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants