Use JsSourceParser as default parser for AstAnalyser class #227
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for contributing, could you update the type here? Line 81 in 7422acb |
|
You can probably write a new test in https://github.com/NodeSecure/js-x-ray/blob/master/test/AstAnalyser.spec.js If we declare the class without any parser and then use it (it should not throw any error). |
PierreDemailly
requested changes
Feb 1, 2024
PierreDemailly
approved these changes
Feb 2, 2024
fraxken
approved these changes
Feb 2, 2024
|
@allcontributors please add @madina0801 for code |
|
I've put up a pull request to add @madina0801! 🎉 |
This was referenced Jun 5, 2024
This was referenced Jul 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #223
It was suspiciously easy, let me know if there are any issues :)