Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use JsSourceParser as default parser for AstAnalyser class #223

Closed
fraxken opened this issue Jan 30, 2024 · 2 comments · Fixed by #227
Closed

Use JsSourceParser as default parser for AstAnalyser class #223

fraxken opened this issue Jan 30, 2024 · 2 comments · Fixed by #227
Assignees
@madina0801
Labels
good first issue Good for newcomers

Comments

@fraxken
Copy link
Member

fraxken commented Jan 30, 2024

The parser argument in the constructor of AstAnalyser class is currently required:

https://github.com/NodeSecure/js-x-ray/blob/master/src/AstAnalyser.js#L18

For me we should make it optional and assign new JsSourceParser() by default.
@fraxken fraxken added the good first issue Good for newcomers label Jan 30, 2024
@madina0801
Copy link
Contributor

Hi, I would like to work on it! Could you please assign it to me?

@jean-michelet
Copy link
Contributor

jean-michelet commented Jan 31, 2024 •
edited
Loading

Go for it @madina0801, I think the issue is quite simple.

@madina0801 madina0801 mentioned this issue Jan 31, 2024
Merged
@PierreDemailly PierreDemailly linked a pull request Jan 31, 2024 that will close this issue
Use JsSourceParser as default parser for AstAnalyser class #227
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@madina0801 madina0801

Labels
good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use JsSourceParser as default parser for AstAnalyser class madina0801/js-x-ray
3 participants
@fraxken @madina0801 @jean-michelet