-
-
Notifications
You must be signed in to change notification settings - Fork 14.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
vigra: enable tests #375853
vigra: enable tests #375853
Conversation
b9ecb80
to
ab9e6b6
Compare
ab9e6b6
to
7ff2794
Compare
7ff2794
to
fd78733
Compare
|
|
@autra, could you help review this PR? With parallel build enabled, the build time should be faster. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks fine to me. The build time doesn't seem too bad. I've seen plenty of packages that takes a lot longer (ifcopenshell build itself is far longer, gdal tests are far longer too etc), so I'd vote to include the tests. I don't know if there is a global policy to choose between the 2 though.
Successfully created backport PR for |
This PR enables testing of upstream-provided test cases for the package
vigra
. and switch on the tests during the build.The test cases took a significant amount of time to run (several minutes, while the build only took 15 seconds). Whether to enable the test during build or in a package test (under
passthru.tests
) is debatable.Update: Now the test is available as
vigra.tests.check
.Benchmark on a 8-core, 16 logical core laptop:
Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.