Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vigra: unstable-2022-01-11 -> 1.12.1 #375773

Merged
merged 1 commit into from
Jan 22, 2025
Merged

Conversation

autra
Copy link
Contributor

@autra autra commented Jan 22, 2025

Things done

Update vigra to 1.12.1 and switch to openex_3.

The original motivation is #367406

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@autra
Copy link
Contributor Author

autra commented Jan 22, 2025

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 375773


x86_64-linux

✅ 5 packages built:
  • digikam
  • enblend-enfuse
  • hugin
  • saga
  • vigra

@autra autra requested review from ShamrockLee, Artturin and fabianhjr and removed request for ShamrockLee and Artturin January 22, 2025 12:20
@autra
Copy link
Contributor Author

autra commented Jan 22, 2025

I've asked some reviews, following the suggestions of github, sorry if it's not relevant (there is no maintainers for this package).

@ShamrockLee
Copy link
Contributor

I'm not familiar with this library, but I'll review the code and leave some general suggestions.

Are there some specific tests I could perform? The upstream has prepared some tests, but they don't get run as this package doesn't come with doCheck = true. Is there any reason blocking the tests to run for this package? It would be easier for reviewers to approve a change with the checks.

pkgs/development/libraries/vigra/default.nix Outdated Show resolved Hide resolved
pkgs/development/libraries/vigra/default.nix Outdated Show resolved Hide resolved
pkgs/development/libraries/vigra/default.nix Outdated Show resolved Hide resolved
@autra autra added the backport release-24.11 Backport PR automatically label Jan 22, 2025
@ShamrockLee ShamrockLee mentioned this pull request Jan 22, 2025
13 tasks
@ShamrockLee
Copy link
Contributor

I managed to run the tests on this update and will merge this PR after the above reviews are suggested.

@autra autra mentioned this pull request Jan 22, 2025
13 tasks
@autra
Copy link
Contributor Author

autra commented Jan 22, 2025

Is there any reason blocking the tests to run for this package? It would be easier for reviewers to approve a change with the checks.

I don't know :-) This package is affected by the switch from openexr 2 to 3. We were packaging an unstable version and apparently nobody has significantly touched this since 2022... I'll address your comments and will try dependent project to see if they seems to work correctly.

@autra
Copy link
Contributor Author

autra commented Jan 22, 2025

@ShamrockLee thanks for the review and suggestions!

I didn't directly test vigra, but I tested hugin, which seems to work correctly (it has stitched some photos to a panorama, so I guess it used vigra somewhere :-)).

Copy link
Contributor

@ShamrockLee ShamrockLee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ShamrockLee ShamrockLee merged commit 7046248 into NixOS:master Jan 22, 2025
40 of 43 checks passed
@nixpkgs-ci
Copy link
Contributor

nixpkgs-ci bot commented Jan 22, 2025

Successfully created backport PR for release-24.11:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants