-
-
Notifications
You must be signed in to change notification settings - Fork 14.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
vigra: unstable-2022-01-11 -> 1.12.1 #375773
Conversation
2d16eb3
to
7b7b77d
Compare
|
I've asked some reviews, following the suggestions of github, sorry if it's not relevant (there is no maintainers for this package). |
I'm not familiar with this library, but I'll review the code and leave some general suggestions. Are there some specific tests I could perform? The upstream has prepared some tests, but they don't get run as this package doesn't come with |
I managed to run the tests on this update and will merge this PR after the above reviews are suggested. |
I don't know :-) This package is affected by the switch from openexr 2 to 3. We were packaging an unstable version and apparently nobody has significantly touched this since 2022... I'll address your comments and will try dependent project to see if they seems to work correctly. |
06af16f
to
29a1440
Compare
@ShamrockLee thanks for the review and suggestions! I didn't directly test vigra, but I tested hugin, which seems to work correctly (it has stitched some photos to a panorama, so I guess it used vigra somewhere :-)). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Hash checked via
nix-prefetch-github
. - Checks run via vigra: enable tests #375853
Successfully created backport PR for |
Things done
Update vigra to 1.12.1 and switch to openex_3.
The original motivation is #367406
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.