Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cnijfilter2: Add patch for missing include in keytext.c #370156

Closed
wants to merge 1 commit into from

Conversation

martiert
Copy link
Contributor

@martiert martiert commented Jan 2, 2025

keytext.c uses malloc and free, but without the include. This broke when the packages was moved to pkgs/by-name and everyone had to rebuild it

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

keytext.c uses malloc and free, but without the include. This broke when
the packages was moved to pkgs/by-name and everyone had to rebuild it
@github-actions github-actions bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 labels Jan 2, 2025
Copy link
Contributor

@NovaViper NovaViper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested the change in my flake and the new patchfile lets the package successfully build!

@wegank wegank added the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Jan 3, 2025
@NovaViper
Copy link
Contributor

Also @martiert, could you edit the PR's description to mention that it fixes #368651, #368624 ?

@NovaViper NovaViper mentioned this pull request Jan 3, 2025
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 12.approvals: 1 This PR was reviewed and approved by one reputable person
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants