Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cnijfilter2: fix build #370706

Closed
wants to merge 2 commits into from
Closed

cnijfilter2: fix build #370706

wants to merge 2 commits into from

Conversation

bandithedoge
Copy link
Contributor

Fixes #368651, #368624

This package was broken because of GCC 14 turning implicit function declaration warnings into errors. Fixed with a patch suggested by @stereomato.

Thanks to autoPatchelfHook being used the cnijlgmon3 executable can now find libstdc++.so.6.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

The resulting binaries are automatically patched to find required dynamic libraries.
`cnijlgmon3` no longer fails because of libstdc++.so.6.
@github-actions github-actions bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 labels Jan 3, 2025
@lucasew
Copy link
Contributor

lucasew commented Jan 3, 2025

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 370706


x86_64-linux

✅ 1 package built:
  • cnijfilter2

@NovaViper
Copy link
Contributor

This looks like it's a duplicate of #370156

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Build failure: cnijfilter2
3 participants