mumble: 1.4.287 -> 1.5.634

[felixsinger]

Description of changes

There are still issues left and at least one more release candidate is expected. So for now this pull request just serves for build-tesing.

Things done

• Built on platform(s)
  • x86_64-linux
  • aarch64-linux
  • x86_64-darwin
  • aarch64-darwin
• For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
  • sandbox = relaxed
  • sandbox = true
• Tested, as applicable:
  • NixOS test(s) (look inside nixos/tests)
  • and/or package tests
  • or, for functions and "core" functionality, tests in lib/tests or pkgs/test
  • made sure NixOS tests are linked to the relevant packages
• Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
• Tested basic functionality of all binary files (usually in ./result/bin/)
• 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
  • (Package updates) Added a release notes entry if the change is major or breaking
  • (Module updates) Added a release notes entry if the change is significant
  • (Module addition) Added a release notes entry if adding a new NixOS module
• Fits CONTRIBUTING.md.

---

Add a 👍 reaction to pull requests you find important.

[infinisil]

Could you please remove me as a maintainer? I don't have a lot of time to maintain packages recently, and I'm not using mumble anymore right now either.

Perhaps @K900 would be willing to become a maintainer instead?

[felixsinger]

@Lilacious volunteered to join as a maintainer.

@infinisil Could you create a pull request? I feel it's a bit weird to remove other people. I rather would like to ack it :)

[infinisil]

Fair enough, will do, thanks!

[infinisil]

( #302858 )

[Lilacious]

Updated to a new release candidate.

[felixsinger]

Mumble stable 1.5.634 just got released.

[felixsinger]

@infinisil I assume you are not interested in reviewing. So I'm removing you from reviewers, since you said earlier that you don't use it anyway. You are welcome to review though!

[keenanweaver]

Getting a build error with the overlay:

$ git -c fetch.prune=false fetch --no-tags --force https://github.com/NixOS/nixpkgs master:refs/nixpkgs-review/0 pull/298758/head:refs/nixpkgs-review/1
$ git worktree add /home/keenan/.cache/nixpkgs-review/pr-298758-1/nixpkgs 3f5dbb066792fedc1d8cd889fb60c7ac58444f6c
Preparing worktree (detached HEAD 3f5dbb066792)
Updating files: 100% (41127/41127), done.
HEAD is now at 3f5dbb066792 Merge pull request #312883 from christoph-heiss/floorp/update
$ git merge --no-commit --no-ff 60535327cfee93c99da29a7dbdebcc704b6934f3
Automatic merge went well; stopped before committing as requested
$ nix build --file /nix/store/n0ahhfycjdkwvzzr2sq8h8z71n2w5yzk-nixpkgs-review-2.10.4/lib/python3.11/site-packages/nixpkgs_review/nix/review-shell.nix --nix-path nixpkgs=/home/keenan/.cache/nixpkgs-review/pr-298758-1/nixpkgs nixpkgs-overlays=/tmp/tmpurgzhetp --extra-experimental-features nix-command no-url-literals --no-link --keep-going --no-allow-import-from-derivation --option build-use-sandbox relaxed --argstr system x86_64-linux --argstr nixpkgs-path /home/keenan/.cache/nixpkgs-review/pr-298758-1/nixpkgs --argstr nixpkgs-config-path /tmp/tmpu0y7gcay.nix --argstr attrs-path /home/keenan/.cache/nixpkgs-review/pr-298758-1/attrs.nix
error: builder for '/nix/store/lw76ignrp1ny3zm9jfhnmyz4vaxmp4ia-mumble-1.5.634.drv' failed with exit code 2;
       last 25 log lines:
       > [ 42%] Building CXX object src/CMakeFiles/shared.dir/ServerResolverRecord.cpp.o
       > [ 42%] Building CXX object src/CMakeFiles/shared.dir/SSL.cpp.o
       > [ 43%] Building CXX object src/CMakeFiles/shared.dir/SSLLocks.cpp.o
       > [ 43%] Building CXX object src/CMakeFiles/shared.dir/Timer.cpp.o
       > [ 43%] Building CXX object src/CMakeFiles/shared.dir/UnresolvedServerAddress.cpp.o
       > [ 43%] Built target se
       > [ 43%] Building CXX object src/CMakeFiles/shared.dir/Version.cpp.o
       > [ 44%] Building CXX object src/CMakeFiles/shared.dir/VolumeAdjustment.cpp.o
       > [ 44%] Building CXX object src/CMakeFiles/shared.dir/crypto/CryptographicHash.cpp.o
       > [ 44%] Building CXX object src/CMakeFiles/shared.dir/crypto/CryptographicRandom.cpp.o
       > [ 44%] Building CXX object src/CMakeFiles/shared.dir/crypto/CryptStateOCB2.cpp.o
       > /build/source/src/MumbleProtocol.cpp: In instantiation of 'bool Mumble::Protocol::UDPDecoder<role>::decodeAudio_legacy(gsl::span<const unsigned char>, Mumble::Protocol::AudioCodec) [with Mumble::Protocol::Role role = Mumble::Protocol::Role::Client]':
       > /build/source/src/MumbleProtocol.cpp:885:2:   required from here
       > /build/source/src/MumbleProtocol.cpp:784:71: error: conversion from 'uint64_t' {aka 'long long unsigned int'} to 'gsl::span<unsigned char>::size_type' {aka 'unsigned int'} may change value [8;;https://gcc.gnu.org/onlinedocs/gcc/Warning-Options.html#index-Wconversion-Werror=conversion8;;]
       >   784 |                 m_audioData.payload = gsl::span< byte >(payloadBegin, payloadSize);
       >       |                                                                       ^~~~~~~~~~~
       > /build/source/src/MumbleProtocol.cpp: In instantiation of 'bool Mumble::Protocol::UDPDecoder<role>::decodeAudio_legacy(gsl::span<const unsigned char>, Mumble::Protocol::AudioCodec) [with Mumble::Protocol::Role role = Mumble::Protocol::Role::Server]':
       > /build/source/src/MumbleProtocol.cpp:885:2:   required from here
       > /build/source/src/MumbleProtocol.cpp:784:71: error: conversion from 'uint64_t' {aka 'long long unsigned int'} to 'gsl::span<unsigned char>::size_type' {aka 'unsigned int'} may change value [8;;https://gcc.gnu.org/onlinedocs/gcc/Warning-Options.html#index-Wconversion-Werror=conversion8;;]
       > [ 45%] Building CXX object src/CMakeFiles/shared.dir/__/3rdparty/arc4random/arc4random_uniform.cpp.o
       > cc1plus: all warnings being treated as errors
       > make[2]: *** [src/CMakeFiles/shared.dir/build.make:242: src/CMakeFiles/shared.dir/MumbleProtocol.cpp.o] Error 1
       > make[2]: *** Waiting for unfinished jobs....
       > make[1]: *** [CMakeFiles/Makefile2:1203: src/CMakeFiles/shared.dir/all] Error 2
       > make: *** [Makefile:136: all] Error 2
       For full logs, run 'nix log /nix/store/lw76ignrp1ny3zm9jfhnmyz4vaxmp4ia-mumble-1.5.634.drv'.
error: 1 dependencies of derivation '/nix/store/4aw5ai8qwdmg5xhayg0447b7kqrcm39h-mumble-overlay-1.5.634.drv' failed to build
error: 1 dependencies of derivation '/nix/store/pq8g5vk8grvlvjki8b57hidl65l3xlsv-review-shell.drv' failed to build

Link to currently reviewing PR:
https://github.com/NixOS/nixpkgs/pull/298758

1 package failed to build:
mumble_overlay

5 packages built:
ioq3-scion ioquake3 mumble murmur quake3demo

error: build log of '/nix/store/4aw5ai8qwdmg5xhayg0447b7kqrcm39h-mumble-overlay-1.5.634.drv^*' is not available
error: build log of '/nix/store/3k3cngblka7pfrxhj3n901w7b8x8bg84-mumble-overlay-1.5.634' is not available
$ /nix/store/62nhzqm27dadv0czp5gqnnc38xfbi8k4-nix-2.18.2/bin/nix-shell --argstr system x86_64-linux --argstr nixpkgs-path /home/keenan/.cache/nixpkgs-review/pr-298758-1/nixpkgs --argstr nixpkgs-config-path /tmp/tmpu0y7gcay.nix --argstr attrs-path /home/keenan/.cache/nixpkgs-review/pr-298758-1/attrs.nix --nix-path nixpkgs=/home/keenan/.cache/nixpkgs-review/pr-298758-1/nixpkgs nixpkgs-overlays=/tmp/tmpurgzhetp /nix/store/n0ahhfycjdkwvzzr2sq8h8z71n2w5yzk-nixpkgs-review-2.10.4/lib/python3.11/site-packages/nixpkgs_review/nix/review-shell.nix

[RSWilli]

What's the status on this? Any progress?

[Avi-D-coder]

Someone should check this but I don't believe "-D bundled-rnnoise=OFF" is followed by mumble with this version. This means rnnoise should no longer be a dependency, since mumble has vendored there own incompatible version.

https://github.com/mumble-voip/mumble/blob/master/CMakeLists.txt

See mumble-voip/mumble#6395
mumble-voip/mumble@84f759d

https://github.com/NixOS/nixpkgs/blob/60535327cfee93c99da29a7dbdebcc704b6934f3/pkgs/applications/networking/mumble/default.nix#L64

[Lilacious]

Thank you for pointing it out. I didn't encounter any obvious issues testing mumble without "-D bundled-rnnoise=OFF", so I will update the pr soon.

[keenanweaver]

Result of nixpkgs-review pr 298758 run on x86_64-linux 1

6 packages built:

• ioq3-scion
• ioquake3
• mumble
• mumble_overlay
• murmur
• quake3demo

[felixsinger]

Looks good to me. Thanks!

[Guanran928]

Not sure if this is related, but I hit this today after I updated nixpkgs:

mumble-server[3085960]: <W>2024-06-20 18:46:05.086 ServerDB: Opened SQLite database /var/lib/murmur/murmur.sqlite
mumble-server[3085960]: <W>2024-06-20 18:46:05.087 ServerDB: Using SQLite's default rollback journal.
mumble-server[3085960]: <W>2024-06-20 18:46:05.090 Renaming old tables...
mumble-server[3085960]: <W>2024-06-20 18:46:05.108 Generating new tables...
mumble-server[3085960]: <W>2024-06-20 18:46:05.484 Importing old data...
mumble-server[3085960]: <F>2024-06-20 18:46:05.504 SQL Error [INSERT INTO `slog` (`server_id`, `msg`, `msgtime`) SELECT `server_id`, `msg`, `msgtime` FROM `slog_old_1718876765`]: unable to open database file Unable to fetch row
systemd[1]: murmur.service: Main process exited, code=exited, status=1/FAILURE