Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mumble: Add Yuchen He as package maintainer #301213

Merged
merged 1 commit into from
Apr 3, 2024
Merged

Conversation

Lilacious
Copy link
Contributor

#298758

Description of changes

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@Lilacious Lilacious requested a review from felixsinger April 3, 2024 11:15
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels Apr 3, 2024
Copy link
Member

@felixsinger felixsinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please change the commit title to

mumble: Add Yuchen He as package maintainer

@Lilacious Lilacious changed the title mumble: Add new package maintainer mumble: Add Yuchen He as package maintainer Apr 3, 2024
@Lilacious Lilacious changed the title mumble: Add Yuchen He as package maintainer mumble: Add lilacious as package maintainer Apr 3, 2024
@wegank
Copy link
Member

wegank commented Apr 3, 2024

The suggestion concerns the commit message, not the title of the PR.

@felixsinger
Copy link
Member

The suggestion concerns the commit message, not the title of the PR.

Right, please change the commit message.

@Lilacious Lilacious changed the title mumble: Add lilacious as package maintainer mumble: Add new package maintainer Apr 3, 2024
Copy link
Member

@felixsinger felixsinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. No need to change the pull request title back to the original state, though. Please try to keep the information given on the pull request equal to the commits. The GitHub workflow makes it a bit harder, since pull request and commit(s) are not necessarily tied to each other. So keeping both in sync might add some extra work, but well.. That's how it is with GitHub.

Anyway, no worries. Not an issue for this one here, just saying. Just keep it in mind for the next time. :)

Edit: I'm actually more interested in giving the commits more quality, but others might be more focused on the pull request side. So that's why I would like to keep them in sync.

@wineee wineee changed the title mumble: Add new package maintainer mumble: Add Yuchen He as package maintainer Apr 3, 2024
@wineee wineee merged commit 30f5e35 into NixOS:master Apr 3, 2024
26 of 27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants