-
-
Notifications
You must be signed in to change notification settings - Fork 14.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
mumble: Add Yuchen He as package maintainer #301213
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please change the commit title to
mumble: Add Yuchen He as package maintainer
The suggestion concerns the commit message, not the title of the PR. |
Right, please change the commit message. |
Signed-off-by: Yuchen He <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. No need to change the pull request title back to the original state, though. Please try to keep the information given on the pull request equal to the commits. The GitHub workflow makes it a bit harder, since pull request and commit(s) are not necessarily tied to each other. So keeping both in sync might add some extra work, but well.. That's how it is with GitHub.
Anyway, no worries. Not an issue for this one here, just saying. Just keep it in mind for the next time. :)
Edit: I'm actually more interested in giving the commits more quality, but others might be more focused on the pull request side. So that's why I would like to keep them in sync.
#298758
Description of changes
Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.