-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Recharging point & plan revisions #793
Open
nick-knowles
wants to merge
6
commits into
NeTEx-CEN:next
Choose a base branch
from
nick-knowles:Recharging-Point-&-Plan-revisions
base: next
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
b4764d6
Recharging revisions - Add rechargiungStation and Recharging Bay
nick-knowles b2bcb57
Add missing height to WaitingEquipment
nick-knowles 788cb44
Recharging point revisions for VVS
nick-knowles ebe61c1
Lint and update documentation tables
github-actions[bot] 5854217
Update NeTEx VDV Example.xml
duexw 9f24315
Lint and update documentation tables
github-actions[bot] File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
236 changes: 138 additions & 98 deletions
236
examples/standards/vdv452/timetable/NeTEx VDV Example.xml
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nick has added support for charging cars at dedicated recharging bays, but these bays are related to the general parking concept, implying that the public can recharge their Teslas etc. at these recharging bays.
The added recharging bays and recharging stations seems fine. But for public use...
The actual VDV need is something else. VDV indicates that they need to model support for opportunity-charging during the time a bus in operation is exchanging passengers at a stop.
They wish to indicate that a certain physical bus stop ( that reads Quay in NeTEx) has an overhead pantograph and also to which recharging station the pantograph is linked.
So forget about recharging bay, which is irrelevant in this case. I also suggest linking the physical Vehicle Recharging-Equipment to the Quay it is serving.
In the example file create a Quay for each relevant physical bus stop. Thus one Quay per VDV - Scheduled Stop Point. Then assign that Quay to the Scheduled Stop Point. This can easliy be automated as nothing hinders using aligned Ids for Quay, Scheduled Stop Point and Passenger Stop Assignment.
Here is the extended StopPlace:
And the additional stop assignment:
And a simplified recharging point assignment:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ulf, I understand your criticism of using the parkingbay element. However, from a VDV452 / VDV462 perspective, we would not like to use the Quay element and we need the RechargingStation element. I agree on the use of VehicleChargingEquipment though. Could we not just have the VehicleChargingEquipments below RechargingStation, like so:
Then we can assign the ScheduledStopPoint elements to the VehicleChargingEquipments without using Quay and without using Parkingbay:
The RechargingStation Element does not need to be below "parkings", it could also have an own enclosing element "rechargingStations"