Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Recharging point & plan revisions #793

Open
wants to merge 6 commits into
base: next
Choose a base branch
from

Conversation

nick-knowles
Copy link
Contributor

Revisions to ReCHARGING EQUIPMENT PROFIEL and RECHARGING PLAN to address VVS issues

a) Add RECHARGING STATION and RECHARGING BAY

b) Allow a VETRHICEL JOURNEY to indicate a preferred VEHICEL EQUIPMENT PROFILE / RECHARGING EQUIPMENT PROFILE

c) ALlow RECHARGING EQUIPMENT PROFILE to state which VEHICLE RECHARGING EQUIPMENTs it ios compatible to
to state

nick-knowles and others added 4 commits October 26, 2024 16:33
Add RechargiungStation and Recharging Bay entities
Was missing a height  - needed for shelters seats etc
Allow VEHICLE JOURNEY to ref a RECHARHING PROFILE. ALLOW RECHARGING PROFIEL to say which VEHCILE CHARGING EQUIPMENT it is compatibel with.
@Aurige Aurige requested a review from duexw October 28, 2024 13:32
@Aurige Aurige mentioned this pull request Oct 28, 2024
@Aurige Aurige added the needs documentation update The NeTEx document needs to be updated label Oct 28, 2024
Copy link
Collaborator

@duexw duexw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am generally OK with the new elements RechargingStation and RechargingBay - many thanks. By re-using the ParkingGroup, we inherit many elements and properties which apply to commercial car parking, but not to recharging public buses. That may be confusing to implementers. they will have to apply some common sense here.

The "VDV" example needs some adjustment

  1. In VDV, the charging point would not be part of the ServiceJourneyPattern - otherwise you would need different ServiceJourneyPatterns depending on whether you actually recharge on a journey or not. VDV just needs the assignment from the scheduled stop point to the recharging bays which could be used from there. This is obviously possible:
    image
    so that's fine in the model, but not in the example.

  2. Minor issue:
    In the XML example, the ValueSet/values/TypeOfPlug is a copy of TypeOf Point. But PlugType "Bus Stop" is confusing
    I can help with fixing the VDV example if necessary.

@ue71603 ue71603 added this to the netex_2.0 milestone Oct 29, 2024
@ue71603 ue71603 added the change-request Additional feature, discussed withe the group and having a proper Change Requet in Basecamp. label Oct 29, 2024
@Aurige
Copy link
Contributor

Aurige commented Oct 29, 2024

Update of the VDV Example needed (assign recharging point to Scheduled stop point)
@duexw to propose an update example, and confirm that we can update the document.

duexw and others added 2 commits November 18, 2024 20:51
@Aurige
Copy link
Contributor

Aurige commented Nov 19, 2024

@duexw requirement: Link RechargingStep to 1 Block ?

Copy link
Collaborator

@Ulf9 Ulf9 Nov 28, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nick has added support for charging cars at dedicated recharging bays, but these bays are related to the general parking concept, implying that the public can recharge their Teslas etc. at these recharging bays.
The added recharging bays and recharging stations seems fine. But for public use...

The actual VDV need is something else. VDV indicates that they need to model support for opportunity-charging during the time a bus in operation is exchanging passengers at a stop.

They wish to indicate that a certain physical bus stop ( that reads Quay in NeTEx) has an overhead pantograph and also to which recharging station the pantograph is linked.

So forget about recharging bay, which is irrelevant in this case. I also suggest linking the physical Vehicle Recharging-Equipment to the Quay it is serving.

In the example file create a Quay for each relevant physical bus stop. Thus one Quay per VDV - Scheduled Stop Point. Then assign that Quay to the Scheduled Stop Point. This can easliy be automated as nothing hinders using aligned Ids for Quay, Scheduled Stop Point and Passenger Stop Assignment.

Here is the extended StopPlace:
image

And the additional stop assignment:
image

And a simplified recharging point assignment:

image

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ulf, I understand your criticism of using the parkingbay element. However, from a VDV452 / VDV462 perspective, we would not like to use the Quay element and we need the RechargingStation element. I agree on the use of VehicleChargingEquipment though. Could we not just have the VehicleChargingEquipments below RechargingStation, like so:
image

Then we can assign the ScheduledStopPoint elements to the VehicleChargingEquipments without using Quay and without using Parkingbay:
image

The RechargingStation Element does not need to be below "parkings", it could also have an own enclosing element "rechargingStations"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
change-request Additional feature, discussed withe the group and having a proper Change Requet in Basecamp. needs documentation update The NeTEx document needs to be updated
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants