Removing spatial indices for some members of parametersgrid_type #75
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Additions
None
Removals
None
Changes
Revised the definition of a selection of variables (all members of
parametersgrid_type) to exclude spatial indices. These variables were identified in issue #73.Also revised definition of
ParametersVarInTransferandParametersVarOutTransferroutines to accommodate changes to the definition ofparametersgrid_type.Testing
The PR-modified code was successfully compiled on MacOS using GNU Fortran (Homebrew GCC 13.1.0) 13.1.0. The program was then executed using the model inputs provided with this repo's main branch. Then,
/test/analysis/compare_outputnc.pywas executed to confirm that gridded outputs match the output from a clean build of the Noah-OM column model. Finally,/test/noahowp_driver_test.f90(i.e.,noahowp_test.exe) was compiled and executed with the inputs associated with this repo's main branch; and outputs were observed to be correct.Notes
None
Todos
None