Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Confirm parameters have correct spatial discretization #73

Closed
SnowHydrology opened this issue Jul 27, 2023 · 2 comments
Closed

Confirm parameters have correct spatial discretization #73

SnowHydrology opened this issue Jul 27, 2023 · 2 comments
Assignees
@SnowHydrology @GreyREvenson

Comments

@SnowHydrology
Copy link
Contributor

Confirm parameters have correct spatial discretization in the noah_om_grid branch.

https://github.com/NOAA-OWP/noah-owp-modular/blob/noah_om_grid/src/ParametersGridType.f90
@SnowHydrology
Copy link
Contributor Author

SnowHydrology commented Jul 28, 2023 •
edited by GreyREvenson
Loading

After some investigation, we can set the following to be scalar (i.e., not 2d arrays):

  • TFRZ
  • HSUB
  • HVAP
  • HFUS
  • CWAT
  • CICE
  • CPAIR
  • TKWAT
  • TKICE
  • TKAIR
  • RAIR
  • RW
  • DENH20
  • DENICE
  • THKW
  • THKO
  • THKQTZ
  • SWEMX
  • TAU0
  • GRAIN_GROWTH
  • EXTRA_GROWTH
  • DIRT_SOOT
  • BATS_COSZ
  • BATS_VIS_NEW
  • BATS_NIR_NEW
  • BATS_VIS_AGE
  • BATS_NIR_AGE
  • BATS_VIS_DIR
  • BATS_NIR_DIR
  • ALB_ICE
  • ALB_LAK
  • OMEGAS
  • BETADS
  • BETAIS
  • 02
  • C02
  • GRAV

Some of them are constants that can be added to a constants module some time in the future (see #5).

@GreyREvenson GreyREvenson mentioned this issue Aug 2, 2023
Merged
SnowHydrology pushed a commit that referenced this issue Aug 9, 2023
@GreyREvenson
Removing spatial indices for some members of parametersgrid_type (#75)
a39c372 
Co-authored-by: K. Jennings <[email protected]>

Closes #73
@SnowHydrology
Copy link
Contributor Author

Closed by #75

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@SnowHydrology SnowHydrology

@GreyREvenson GreyREvenson

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@SnowHydrology @GreyREvenson