Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PORT] Updates TGUI to v4.3.2 #5400

Merged

Conversation

LikeLakers2
Copy link
Collaborator

@LikeLakers2 LikeLakers2 commented Feb 10, 2025

About The Pull Request

This PR ports the following PR from tgstation:

While I did check if a few important interfaces still worked (character setup, round logs, the LUA editor, the say box, and a couple others), I have not done an extensive test. There are simply far too many interfaces to check all of them. Please let me know if this has broken any interfaces.

Why It's Good For The Game

Housekeeping.

Changelog

🆑 MichiRecRoom, jlsnow301
code: TGUI dependencies have been updated. This should not result in any player-facing changes, but suffice to say: PLEASE LET ME KNOW IF THIS HAS BROKEN ANY INTERFACES.
/:cl:

@LikeLakers2 LikeLakers2 force-pushed the project/ports/tg-79895-tgui-432 branch from 5efd3d3 to e31617f Compare February 10, 2025 08:51
Woah! Shiny!

Updates most of tgui's internals. Nothing player facing. Tested and
working
Good housekeeping
N/A nothing player facing
@LikeLakers2 LikeLakers2 force-pushed the project/ports/tg-79895-tgui-432 branch 3 times, most recently from 43cb8d7 to 9a54b7a Compare February 10, 2025 09:20
Issues that came up from tgui-build. Mostly react keys.
Bug fixes
N/A nothing player facing
@LikeLakers2 LikeLakers2 force-pushed the project/ports/tg-79895-tgui-432 branch from 9a54b7a to 98dac8e Compare February 10, 2025 09:24
@LikeLakers2
Copy link
Collaborator Author

LikeLakers2 commented Feb 10, 2025

While I did check if a few important tgui interfaces still worked (character setup, round logs, the LUA editor, the say box, and a couple others), I have not done an extensive test. There are simply far too many interfaces to check all of them.

Please testmerge first, and let me know if this has broken any interfaces.

@LikeLakers2 LikeLakers2 marked this pull request as ready for review February 10, 2025 20:30
@Absolucy Absolucy merged commit eaf56ea into Monkestation:master Feb 11, 2025
29 checks passed
github-actions bot added a commit that referenced this pull request Feb 11, 2025
@LikeLakers2 LikeLakers2 deleted the project/ports/tg-79895-tgui-432 branch February 11, 2025 11:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants