Some small SSparticle_weather fixes
#5256
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LikeLakers2
force-pushed
the
project/ss-particle-weather/these-are-supposed-to-null-something
branch
from
988376c to
50dd70b
Compare
LikeLakers2
force-pushed
the
project/ss-particle-weather/these-are-supposed-to-null-something
branch
from
50dd70b to
54f1fe4
Compare
LikeLakers2
changed the title
next_hit(_eclipse) when running the weatherSSparticle_weather fixes
LikeLakers2
force-pushed
the
project/ss-particle-weather/these-are-supposed-to-null-something
branch
from
54f1fe4 to
8cc1ff4
Compare
This was referenced Feb 3, 2025
Open
LikeLakers2
deleted the
project/ss-particle-weather/these-are-supposed-to-null-something
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About The Pull Request
This PR should fix a hard-del that's been repeatedly reported, regarding particle weather stuff.
Additionally, I happened to notice that
/datum/controller/subsystem/particle_weather/proc/run_weatherwas trying to nullifynext_hit(_eclipse)... but seemed to instead nullify the parameter. So I fixed that too.As an aside... I do think that SSparticle_weather should be rewritten. Right now, it seems to duplicate much of its functionality to have both regular weather and eclipse weather running at once.
Why It's Good For The Game
Bugs!
edit: and hard-dels!
Changelog
I don't believe SSparticle_weather even runs on any of our active maps, so this probably isn't a player-facing change.
That said, I'm going to put these here so the relevant flaky test reports automatically close when this is merged:
Fixes #5265
Fixes #5254
Fixes #5252