Fix issues where exitstatus could be nil #538
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In cases where the process did not exit properly, exitstatus could be
nil. This, in turn, is being sent to exit, which causes
in `exit': no implicit conversion from nil to integer (TypeError)
exception, instead of exiting as expected.
jrafanie
approved these changes
Jan 3, 2025
|
Yeah I would love if Ruby had a "system, but exit me with the same status code if it fails" type of method. |
what a coincidence, that's exactly what I'd name it... 🤣 It's a good thing naming is so easy. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In cases where the process did not exit properly, exitstatus could be nil. This, in turn, is being sent to exit, which causes
exception, instead of exiting as expected.
@jrafanie Please review.