Merge pull request #538 from Fryguy/better_exit

Fix issues where exitstatus could be nil
ManageIQ · Jan 3, 2025 · 43e6a84 · 43e6a84
2 parents 9ac5a5c + 6324841
commit 43e6a84
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/lib/manageiq/rpm_build/helper.rb b/lib/manageiq/rpm_build/helper.rb
@@ -11,13 +11,13 @@ def where_am_i
 
       def shell_cmd(cmd, env = {})
         puts_shell_cmd(cmd, env)
-        exit $?.exitstatus unless system(env, cmd.to_s)
+        exit($?.exitstatus || 1) unless system(env, cmd.to_s)
       end
 
       def shell_cmd_in_venv(cmd, venv, env = {})
         puts_shell_cmd(cmd, env, "(venv)")
         cmd = "source #{venv.join("bin/activate")}; #{cmd}; deactivate"
-        exit $?.exitstatus unless system(env, cmd.to_s)
+        exit($?.exitstatus || 1) unless system(env, cmd.to_s)
       end
 
       def puts_shell_cmd(cmd, env, prefix = "")