-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add API for Token information #374
Comments
|
It's better to open it only for KUAI first.
No limit.
No approve. cc @Keith-CY |
I doubt if it's feasible to only support for Kuai, because it's impossible to differentiate requests from projects built by kuai.
If the request is not limited by some rule, it will be used to attack the service. E.g., sending 100,000 requests in a minute
If the submission is not audited, it will be used to harm the service, e.g. update the |
frontend pr: Magickbase/ckb-explorer-frontend#127 |
I found the UI design is slightly different from the PRD In PRD, there is a dialog with options Another question is about Please check @Sven-TBD Besides, I would suggest adding a button on the token detail page for users to submit a modification. |
I guess this is because I made two version, the one with dialog is on the original version and is deleted after a meeting. And I put the report button on the original version which should be on the latest one. BTW, do we still need the dialog? Based on the last meeting we had about the Token API things, the dialog should be deleted because the user could modify the Token Info only on the Token Information page. The PRD has been updated, and I put the report button here. |
Got it, I think the dialog for choosing the next step is unnecessary if they can modify token info on the token detail page |
Before modifying the info of a token, its original info is expected to be filled in the form. So all fields of Now Besides, I found that |
According to the discussion yesterday, I need 2 more fields returned in the SUDT info API
|
returns
|
I found a typo in PRD that |
Ignore total_amount update PR: nervosnetwork/ckb-explorer#1615 |
|
It should be fixed by Magickbase/ckb-explorer-frontend#249 The mismatched |
Verified. |
Currently, the browser provides a method for developers to upload Token Info via email to the developer community. However, this method is no longer sufficient to meet the needs of new frameworks like Kuai for SUDT development. Instead, an API for Token Info uploading should be introduced as a replacement.
Current way
Related part in Kuai
The text was updated successfully, but these errors were encountered: