Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix modification of token info #249

Merged
merged 3 commits into from
Feb 6, 2024
Merged

Conversation

Keith-CY
Copy link
Member

@Keith-CY Keith-CY commented Feb 5, 2024

  1. fix typehash when the it's going to update token instead of create new one;
  2. remove sudt(deprecated) from the token type list because sudt(deprecated) is actually never used.

Ref: Magickbase/ckb-explorer-public-issues#374 (comment)

1. fix typehash when the it's going to update token instead of
create new one;
2. remove sudt(deprecated) from the token type list because
sudt(deprecated) is actually never used
Copy link

vercel bot commented Feb 5, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
ckb-explorer-frontend-in-magickbase-repo ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 5, 2024 0:15am

@FrederLu
Copy link

FrederLu commented Feb 5, 2024

image

Now there is only Simple UDT to choose from, and the pop-up window also displays it by default. Can it be selected by default when submitting?
Now user will be confused. All other required fields have been filled in, but the submit button cannot be clicked. The problem is that Simple UDT seems to be selected, but it still needs to be selected again in the drop-down list.

@FrederLu
Copy link

FrederLu commented Feb 5, 2024

image

When using Submit Token info, if it is found that there is already email information, there will be an exception prompt.

@zmcNotafraid The interface also needs to be adjusted.

@Keith-CY
Copy link
Member Author

Keith-CY commented Feb 5, 2024

image Now there is only `Simple UDT` to choose from, and the pop-up window also displays it by default. Can it be selected by default when submitting? Now user will be confused. All other required fields have been filled in, but the submit button cannot be clicked. The problem is that `Simple UDT` seems to be selected, but it still needs to be selected again in the drop-down list.

This happens after language is changed and is caused by unsetting status incorrectly, now it should be fixed by 21e9cd7

@Keith-CY
Copy link
Member Author

Keith-CY commented Feb 5, 2024

image When using `Submit Token info`, if it is found that there is already email information, there will be an exception prompt.

@zmcNotafraid The interface also needs to be adjusted.

It should be fixed by nervosnetwork/ckb-explorer#1618 and its error message has been added by 566354d

@zmcNotafraid
Copy link
Member

image When using `Submit Token info`, if it is found that there is already email information, there will be an exception prompt.

@zmcNotafraid The interface also needs to be adjusted.

PR: nervosnetwork/ckb-explorer#1618
it will returns code: 1037, status: 400, title: "Token is required when you update udt info" error

@Keith-CY Keith-CY merged commit e5d8ebb into develop Feb 6, 2024
8 checks passed
@Keith-CY Keith-CY deleted the fix-token-info-modification branch February 6, 2024 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants