Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Token api #210

Merged
merged 51 commits into from
Feb 4, 2024
Merged

Token api #210

merged 51 commits into from
Feb 4, 2024

Conversation

Keith-CY
Copy link
Member

@Keith-CY Keith-CY commented Jan 16, 2024 •
edited
Loading

zhangyouxin and others added 24 commits January 4, 2024 12:50
@zhangyouxin
feat: token api
63ec48e 
chore: select token type

chore: change to comments
@zhangyouxin
chore: fix name typo
4684e21
@zhangyouxin
Merge branch 'develop' into token-api
2c208f4
@zhangyouxin
chore: update token info
2ae7b0b
@Keith-CY
Merge branch 'develop' into token-api
e6db840
@zhangyouxin
Merge branch 'develop' into token-api
fd35781 
Signed-off-by: Shinya <[email protected]>
@zhangyouxin
chore: change to comments
b630276
@zhangyouxin
chore: change request param typehash to lower case
6d4c0d4
@zhangyouxin
Merge branch 'develop' into token-api
9615e35 
Signed-off-by: Shinya <[email protected]>
@zhangyouxin
chore: yarn install
4721f0c
@zhangyouxin
chore: resolve eslint error
a6950f0
@zhangyouxin
feat: use css animation when dropdown open
33424cf
@zhangyouxin @Keith-CY
Update src/components/SubmitTokenInfo/LabeledInput.tsx
ca963bf 
Co-authored-by: Chen Yu <[email protected]>
Signed-off-by: Shinya <[email protected]>
@zhangyouxin
feat: suppport keyborder up/down in select component
680d409
@zhangyouxin
chore: loading state of submit button
e58b5b5
@zhangyouxin
chore: fix typo
e694ee7
@zhangyouxin
chore: allow 0 in decimals
5859a54
@zhangyouxin
chore: pass in hash type from config
96ae568
@Keith-CY
fix: clear form when the dialog is dismissed
2ea080e
@Keith-CY
fix: fix selection in token info dialog
95d4d2b
@Keith-CY
fix: fix error status of fields
085fb1d
@Keith-CY
feat: adopt token form in footer and update token email template
98548f2 
1. show the token form on submitting token from footer
2. remove sudt section from the email template of token info
submission
@Keith-CY
feat: update the arrow of common selection component
781c3d4
@Keith-CY
Merge branch 'develop' into token-api
3562e3a
@vercel Vercel
Copy link

vercel bot commented Jan 16, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
ckb-explorer-frontend-in-magickbase-repo ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 4, 2024 4:06am

@FrederLu
Copy link

FrederLu commented Feb 2, 2024 •
edited
Loading

image Unable to click the `Logo` button and upload images. image Clicking the `Submit Token Info` button on the `NFT Collection` page cannot bring up the pop-up window.

#210 (comment)

Let’s also look at the issues here.

@Keith-CY
Copy link
Member Author

Keith-CY commented Feb 2, 2024

image Unable to click the `Logo` button and upload images. image Clicking the `Submit Token Info` button on the `NFT Collection` page cannot bring up the pop-up window.

#210 (comment)

Let’s also look at the issues here.

It's expected to invoke the email client to submit NFT info because NFT information is not covered in the form.

Submission of NFT info was done by sending an email, so I kept it, as mentioned as point 4 in #210 (comment)

@FrederLu
Copy link

FrederLu commented Feb 2, 2024

It's expected to invoke the email client to submit NFT info because NFT information is not covered in the form.

Submission of NFT info was done by sending an email, so I kept it, as mentioned as point 4 in #210 (comment)

2024-02-02.13.50.33.mov

If we use email to submit information, this entry should be retained, but now after clicking and reopening the page, nothing happens.

@FrederLu FrederLu mentioned this pull request Feb 2, 2024
Closed
@FrederLu
Copy link

FrederLu commented Feb 2, 2024

image image

User's Report template style can refer to prd optimization.

@Keith-CY
Copy link
Member Author

Keith-CY commented Feb 2, 2024

image image
User's Report template style can refer to prd optimization.

This is what pre-filled in my e-mail
image

May I know which URL you were visiting so I can try to reproduce it.

@FrederLu
Copy link

FrederLu commented Feb 2, 2024

May I know which URL you were visiting so I can try to reproduce it.

https://ckb-explorer-frontend-in-magickbase-repo-8t0l9vdvp-magickbase.vercel.app/sudt/0x5fbce7d80b8f9db63e7b383d25ef14a8f96e181205a9901ff4736d79368d2463

2024-02-02.17.39.46.mov

There is no special link operation, but the templates I see when I click Report are connected together.

@Keith-CY
Copy link
Member Author

Keith-CY commented Feb 2, 2024

May I know which URL you were visiting so I can try to reproduce it.

ckb-explorer-frontend-in-magickbase-repo-8t0l9vdvp-magickbase.vercel.app/sudt/0x5fbce7d80b8f9db63e7b383d25ef14a8f96e181205a9901ff4736d79368d2463

2024-02-02.17.39.46.mov
There is no special link operation, but the templates I see when I click Report are connected together.

I can reproduce this case by the URL you've provided. It should be out of date and please try the template by the preview URL in the second message
#210 (comment)

@FrederLu
Copy link

FrederLu commented Feb 2, 2024

May I know which URL you were visiting so I can try to reproduce it.

ckb-explorer-frontend-in-magickbase-repo-8t0l9vdvp-magickbase.vercel.app/sudt/0x5fbce7d80b8f9db63e7b383d25ef14a8f96e181205a9901ff4736d79368d2463
2024-02-02.17.39.46.mov
There is no special link operation, but the templates I see when I click Report are connected together.

I can reproduce this case by the URL you've provided. It should be out of date and please try the template by the preview URL in the second message #210 (comment)

image

Well, that was a problem with my previous link, and the style has been modified on the new preview.

@Keith-CY
Copy link
Member Author

Keith-CY commented Feb 4, 2024

After clicking on the usDT details, and then clicking on the Inscription details, the Modify Token Info button information will be displayed in an instant. It feels like a page cache when it feels.

The crash-like flash is caused by loading status, the modify token info button is displayed by default, and hidden when the type of udt is confirmed to be an inscription after data is fetched.

Commit 2f84059 adds a loading effect to avoid the flash

@FrederLu
Copy link

FrederLu commented Feb 4, 2024

The known issues discovered have basically been resolved, and there are still a few issues for the time being.

image image image

The length of the Chinese/English Confirm button will become longer when clicked, and there is an additional .. after the text.

2024-02-04.11.09.11.mov

The Token Type input style is abnormal when switching between Chinese and English without refreshing the page.

image

There is no response when clicking the Upload button.

image

Confirm the template style submitted here and whether there is a Chinese template. @Sven-TBD

@Keith-CY
Copy link
Member Author

Keith-CY commented Feb 4, 2024

The length of the Chinese/English Confirm button will become longer when clicked, and there is an additional .. after the text.

The Token Type input style is abnormal when switching between Chinese and English without refreshing the page.

Button width and default selected token type between EN and ZH pages should be fixed by commits 5713401 and 6730b40

There is no response when clicking the Upload button.

I cannot reproduce this case, could you send me the URL to have a try

@FrederLu
Copy link

FrederLu commented Feb 4, 2024 •
edited
Loading

There is no response when clicking the Upload button.

I cannot reproduce this case, could you send me the URL to have a try

Chrome version 103.0.5060.114 (official version) (arm64)

Submit Token Info
https://ckb-explorer-frontend-in-magickbase-repo-yhd60tq5i-magickbase.vercel.app/tokens

Modify Token Info
https://ckb-explorer-frontend-in-magickbase-repo-yhd60tq5i-magickbase.vercel.app/sudt/0x5fbce7d80b8f9db63e7b383d25ef14a8f96e181205a9901ff4736d79368d2463

@Keith-CY
Copy link
Member Author

Keith-CY commented Feb 4, 2024

There is no response when clicking the Upload button.

I cannot reproduce this case, could you send me the URL to have a try

Chrome version 103.0.5060.114 (official version) (arm64)

Submit Token Info ckb-explorer-frontend-in-magickbase-repo-yhd60tq5i-magickbase.vercel.app/tokens

Modify Token Info ckb-explorer-frontend-in-magickbase-repo-yhd60tq5i-magickbase.vercel.app/sudt/0x5fbce7d80b8f9db63e7b383d25ef14a8f96e181205a9901ff4736d79368d2463

Both links work well for me, need help from @Sven-TBD @WhiteMinds

@poor-defined
Copy link

I dont think it's necessary to provide a Chinese version. On template, do we need the NFT description as well? @zmcNotafraid

@poor-defined
Copy link

There is no response when clicking the Upload button.

I cannot reproduce this case, could you send me the URL to have a try

Chrome version 103.0.5060.114 (official version) (arm64)
Submit Token Info ckb-explorer-frontend-in-magickbase-repo-yhd60tq5i-magickbase.vercel.app/tokens
Modify Token Info ckb-explorer-frontend-in-magickbase-repo-yhd60tq5i-magickbase.vercel.app/sudt/0x5fbce7d80b8f9db63e7b383d25ef14a8f96e181205a9901ff4736d79368d2463

Both links work well for me, need help from @Sven-TBD @WhiteMinds

Me too, pop up normally

@Keith-CY Keith-CY merged commit c384a2b into develop Feb 4, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FrederLu FrederLu FrederLu approved these changes

@Daryl-L Daryl-L Awaiting requested review from Daryl-L

@WhiteMinds WhiteMinds Awaiting requested review from WhiteMinds

@PainterPuppets PainterPuppets Awaiting requested review from PainterPuppets

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Keith-CY @FrederLu @poor-defined @zhangyouxin