Remove TrainMode
#47
Merged
Remove TrainMode
#47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dreamer2368
changed the title
TrainMode
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR partially addresses the issue #40 .
There were two
TrainMode:UNIVERSALthat trains POD per each component; andINDIVIDUALthat trains POD per each subdomain.While
TrainMode::INDIVIDUALmay provide a little convenience in limited cases, it rather complicates the code implementation significantly, which is becoming a road block for adding more essential features. More fundamentally,TrainMode::INDIVIDUALcan be supported 100% fromTrainMode::UNIVERSAL, thus being redundant.Now
TrainModeis removed from the entire code, simplifying some workflow.