Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lighten/improve the infrastructure #40

Closed
dreamer2368 opened this issue May 7, 2024 · 1 comment
Closed

Lighten/improve the infrastructure #40

dreamer2368 opened this issue May 7, 2024 · 1 comment
Assignees
Labels
enhancement New feature or request

Comments

@dreamer2368
Copy link
Collaborator

dreamer2368 commented May 7, 2024

Several milestones to lighten/improve the infrastructure of the code:

Remove TrainMode

TrainMode::INDIVIDUAL refers to training POD basis per individual subdomain. Even if some subdomains are of the same component, they collect different snapshots and train different POD basis.

In actual production runs, TrainMode::INDIVIDUAL is not really used any more. Furthermore, the same feature can be executed from TrainMode::UNIVERSAL, just using the same mesh for two different components (at the different location). For SubmeshTopologyHandler, this means we're having the same number of components as the number of subdomains, as opposed to one component representing all subdomains.

Having two (unnecessary) different modes and supporting them throughout the workflow is complicating the overall code. The overall structure can be lightened by removing this feature.

Datatype for BasisTag

Unlike single-component ROM, ROM basis for multi-component system has multiple tags: by its component, by variable. The aforementioned TrainMode also changes the component name, further complicating the code.

Considering a future development for interior/interface basis separation, we would want to make a struct for basis tag, containing its component, variable, etc.

@dreamer2368 dreamer2368 self-assigned this May 7, 2024
@dreamer2368 dreamer2368 added the enhancement New feature or request label May 7, 2024
This was referenced Jun 19, 2024
@dreamer2368
Copy link
Collaborator Author

Addressed by #47 and #48 .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant