Bugfix for RAJA's optional RAJA::roctx dependency #1002
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kennyweiss
added
bug
rhornung67
approved these changes
Jan 19, 2023
|
I described the underlying issue on LLNL/blt#618 |
agcapps
approved these changes
Jan 20, 2023
When we specify that `core` depends on `RAJA` in `blt_add_library`, it should transitively depend on RAJA's dependencies. However, the `RAJA::roctx` dependency was not being properly propagated. The latter is present when RAJA is configured with `RAJA_ENABLE_ROCTX`.
kennyweiss
force-pushed
the
bugfix/kweiss/raja-roctx-import
branch
from
6b0a978 to
bc033eb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
coredepends onRAJAinblt_add_library, it should transitively depend on RAJA's dependencies. However, theRAJA::roctxdependency was not being properly propagated. The latter is present when RAJA is configured withRAJA_ENABLE_ROCTX.coreis a CMakeOBJECTlibrary, we're internally setting it up as ablt_register_libraryRAJA::roctxwhen available/needed