Skip to content

Commit

Permalink
Bugfix for RAJA's optional RAJA::roctx dependency
Browse files Browse the repository at this point in the history
When we specify that `core` depends on `RAJA` in `blt_add_library`,
it should transitively depend on RAJA's dependencies. However,
the `RAJA::roctx` dependency was not being properly propagated.
The latter is present when RAJA is configured with `RAJA_ENABLE_ROCTX`.
  • Loading branch information
kennyweiss committed Jan 24, 2023
1 parent 5370e8b commit bc033eb
Showing 1 changed file with 6 additions and 0 deletions.
6 changes: 6 additions & 0 deletions src/axom/core/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -103,6 +103,12 @@ blt_list_append( TO core_depends ELEMENTS blt::hip_runtime IF ENABLE_HIP)
blt_list_append( TO core_depends ELEMENTS openmp IF ENABLE_OPENMP)
blt_list_append( TO core_depends ELEMENTS mpi IF ENABLE_MPI )

# HACK: RAJA's dependencies are not getting added to core due to a bug in
# dependency propagation in blt_register_library. Explicitly add it in the short term.
if(TARGET RAJA::roctx)
list(APPEND core_depends RAJA::roctx)
endif()

#------------------------------------------------------------------------------
# Make/Install the library
#------------------------------------------------------------------------------
Expand Down

0 comments on commit bc033eb

Please sign in to comment.