Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix deprecation warning #37

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix deprecation warning #37

wants to merge 1 commit into from

Conversation

alexej-d
Copy link

@alexej-d alexej-d commented Jun 4, 2019

As of [email protected], the getNodesAtRange method has been renamed to getDescendantsAtRange.

As of [email protected], the `getNodesAtRange` method has been renamed to `getDescendantsAtRange`.
@brendancarney
Copy link
Collaborator

I haven't had time to check this out quite yet. Does the getNodesAtRange method still exist, just deprecated?

@alexej-d
Copy link
Author

alexej-d commented Jul 9, 2019

Yeah, it seems the method still exists. As of the newest version of slate-plugins I am not receiving the deprecation warning anymore

@brendancarney
Copy link
Collaborator

brendancarney commented Jul 26, 2019

Ah, ok so is it no longer deprecated then? looks like it is actually.

@brendancarney
Copy link
Collaborator

So I think I want to leave this open at least until the function is completely removed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants