Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warning: As of slate@0.47, the getNodesAtRange method has been renamed to getDescendantsAtRange. #43

Closed
MatthewHerbst opened this issue Jul 19, 2019 · 2 comments

Comments

@MatthewHerbst
Copy link

I'm getting the following warning when using the lists plugin:

As of slate@0.47, the `getNodesAtRange` method has been renamed to `getDescendantsAtRange`.

I looked at fixing it but it seems doing so would be a breaking change for this library since it would change the Slate version, but I'm unsure.

@brendancarney
Copy link
Collaborator

Thanks for filing the issue! We have a PR open for this, but I'm going to hold off addressing it until the function is removed.

#37

@MatthewHerbst
Copy link
Author

Thanks for taking a look @brendancarney. One issue with not addressing this now is that when Slate upgrades and removes it, it will break anyone who upgrades Slate before there is a fix here and this is upgraded. If not addressing this now, would you be open to at least setting a peerDependency for Slate for this package so people know which versions are supported?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants