-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tests #33
Conversation
test file for diarisation functionality
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is on a good way, please improve these minor things.
scraibe/test/test_audio.py
Outdated
@@ -0,0 +1,99 @@ | |||
import pytest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please remove unused modules
scraibe/test/test_audio.py
Outdated
|
||
|
||
|
||
test_waveform = torch.tensor([]).to('cuda') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please handle cpu as well
scraibe/test/test_audio.py
Outdated
|
||
|
||
test_waveform = torch.tensor([]).to('cuda') | ||
test_sr = 16000 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Global Variables should be upper Case letters
scraibe/test/test_audio.py
Outdated
|
||
@pytest.fixture | ||
def probe_audio_processor(): | ||
"""_summary_ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
add proper doc stings remove summary
scraibe/test/test_audio.py
Outdated
|
||
|
||
|
||
""" def test_cut(probe_audio_processor): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove unused func
scraibe/.pyannotetoken
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove this file!
scraibe/test/test_diarisation.py
Outdated
|
||
|
||
|
||
def test_Diariser_init(diariser_instance): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
something seems to be wrong here
scraibe/test/test_transcriber.py
Outdated
|
||
|
||
|
||
@pytest.mark.parametrize("audio_file, expected_transcription",[("path_to_test_audiofile", "test_transcription")] ) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no spagetti
I applied the Changes which were mentioned in the tests_audio.py file
basics tests for the Diarisation object
Tests Diarisation
Docstrings
Autotranscript test
Docstring got added
Deleted obsolete file
Good job 💯 |
test pull request