Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests #33

Merged
merged 72 commits into from
Apr 29, 2024
Merged

Tests #33

merged 72 commits into from
Apr 29, 2024

Conversation

Tryndaron
Copy link
Collaborator

test pull request

@Tryndaron Tryndaron requested a review from JSchmie January 18, 2024 13:57
@Tryndaron Tryndaron self-assigned this Jan 18, 2024
Copy link
Owner

@JSchmie JSchmie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is on a good way, please improve these minor things.

@@ -0,0 +1,99 @@
import pytest
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove unused modules




test_waveform = torch.tensor([]).to('cuda')
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please handle cpu as well



test_waveform = torch.tensor([]).to('cuda')
test_sr = 16000
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Global Variables should be upper Case letters


@pytest.fixture
def probe_audio_processor():
"""_summary_
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add proper doc stings remove summary




""" def test_cut(probe_audio_processor):
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove unused func

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove this file!




def test_Diariser_init(diariser_instance):
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

something seems to be wrong here




@pytest.mark.parametrize("audio_file, expected_transcription",[("path_to_test_audiofile", "test_transcription")] )
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no spagetti

@JSchmie
Copy link
Owner

JSchmie commented Apr 29, 2024

Good job 💯

@JSchmie JSchmie merged commit fee9f0b into develop Apr 29, 2024
2 checks passed
@JSchmie JSchmie deleted the tests branch April 29, 2024 21:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants