UID2-2329 Add workflow to release packages #29
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,27 @@ | ||
| name: Build and Publish JAR Packages | ||
| run-name: ${{ inputs.release_type == 'Snapshot' && 'Publish pre-release' || format('Release {0}', inputs.release_type)}} Package by @${{ github.actor }} | ||
| on: | ||
| workflow_dispatch: | ||
| inputs: | ||
| release_type: | ||
| type: choice | ||
| description: The type of release | ||
| options: | ||
| - Major | ||
| - Minor | ||
| - Patch | ||
| publish_vulnerabilities: | ||
| type: string | ||
| default: true | ||
| dotnet_version: | ||
| type: string | ||
| default: 5.0 | ||
|
|
||
| jobs: | ||
| build-and-pubish: | ||
| name: Build and publish JAR packages to Maven repository | ||
| uses: IABTechLab/uid2-shared-actions/.github/workflows/shared-publish-to-nuget-versioned.yaml@kcc-UID2-2329-add-dotnet-pipeline | ||
|
There was a problem hiding this comment. Will revert this after IABTechLab/uid2-shared-actions#79 is merged |
||
| with: | ||
| release_type: ${{ inputs.release_type }} | ||
| dotnet_version: ${{ inputs.dotnet_version }} | ||
| secrets: inherit | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -134,7 +134,7 @@ public async Task<RefreshResponse> RefreshAsync(CancellationToken token) | |
|
|
||
| private string GetAssemblyNameAndVersion() | ||
| { | ||
| var version = "5.4.7"; | ||
|
There was a problem hiding this comment. probably change it to 5.4.9 to be in sync with nuspec file at least first There was a problem hiding this comment. won't it become out of sync as soon as we release? There was a problem hiding this comment. right, so the release pipeline increments the version after the pipeline has been kickstarted and before starting to build a new binary and push it to nuget.org, so before we are ready to release, we have to set the version on this line to the next version that we want (the github action pipeline) to release in advance? @cYKatherine ? There was a problem hiding this comment. This conversation has became huge and @jon8787 and I agreed to address this in a separate ticket: https://atlassian.thetradedesk.com/jira/browse/UID2-2964 atm let's keep it manual to update the version here 😢 |
||
| return "uid-client-net-" + version; | ||
| } | ||
|
|
||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,16 +1,17 @@ | ||
| { | ||
| "$schema": "https://raw.githubusercontent.com/dotnet/Nerdbank.GitVersioning/master/src/NerdBank.GitVersioning/version.schema.json", | ||
| "version": "5.4", | ||
| "publicReleaseRefSpec": [ | ||
| "^refs/heads/master$", | ||
| "^refs/heads/v\\d+(?:\\.\\d+)?$" | ||
| ], | ||
| "cloudBuild": { | ||
| "setVersionVariables": true, | ||
| "buildNumber": { | ||
| "enabled": true, | ||
| "includeCommitId": { | ||
| "when": "always" | ||
| } | ||
| } | ||
| } | ||
| } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is this just for dot net version for running to build the binary or does this correspond to some setting in the c# SDK repo?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
or i just would like to know when should we modify this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
At the moment this is used to build/package/test dotnet.
When we bump the version in the code, we can change this in the action interface.