UID2-2329 Add workflow to release packages #29
Conversation
cYKatherine
force-pushed
the
kcc-UID2-2329-add-dotnet-pipeline
branch
2 times, most recently
from
3e5a74c to
bd53aa3
Compare
|
This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation. |
cYKatherine
force-pushed
the
kcc-UID2-2329-add-dotnet-pipeline
branch
from
bd53aa3 to
bd8799b
Compare
| jobs: | ||
| build-and-pubish: | ||
| name: Build and publish JAR packages to Maven repository | ||
| uses: IABTechLab/uid2-shared-actions/.github/workflows/shared-publish-to-nuget-versioned.yaml@kcc-UID2-2329-add-dotnet-pipeline |
There was a problem hiding this comment.
Will revert this after IABTechLab/uid2-shared-actions#79 is merged
cYKatherine
force-pushed
the
kcc-UID2-2329-add-dotnet-pipeline
branch
from
f974622 to
c7384be
Compare
cYKatherine
force-pushed
the
kcc-UID2-2329-add-dotnet-pipeline
branch
from
ff19b28 to
3961757
Compare
cYKatherine
force-pushed
the
kcc-UID2-2329-add-dotnet-pipeline
branch
from
3caa95c to
41decfe
Compare
cYKatherine
force-pushed
the
kcc-UID2-2329-add-dotnet-pipeline
branch
from
011afc5 to
8e9ffe7
Compare
src/UID2.Client/UID2Client.cs
Outdated
| @@ -134,7 +134,7 @@ public async Task<RefreshResponse> RefreshAsync(CancellationToken token) | |||
|
|
|||
| private string GetAssemblyNameAndVersion() | |||
| { | |||
| var version = "5.4.0"; | |||
| var version = "5.4.7"; | |||
There was a problem hiding this comment.
probably change it to 5.4.9 to be in sync with nuspec file at least first
There was a problem hiding this comment.
won't it become out of sync as soon as we release?
There was a problem hiding this comment.
right, so the release pipeline increments the version after the pipeline has been kickstarted and before starting to build a new binary and push it to nuget.org, so before we are ready to release, we have to set the version on this line to the next version that we want (the github action pipeline) to release in advance? @cYKatherine ?
There was a problem hiding this comment.
This conversation has became huge and @jon8787 and I agreed to address this in a separate ticket: https://atlassian.thetradedesk.com/jira/browse/UID2-2964
atm let's keep it manual to update the version here 😢
| default: true | ||
| dotnet_version: | ||
| type: string | ||
| default: 5.0 |
There was a problem hiding this comment.
is this just for dot net version for running to build the binary or does this correspond to some setting in the c# SDK repo?
There was a problem hiding this comment.
or i just would like to know when should we modify this?
There was a problem hiding this comment.
At the moment this is used to build/package/test dotnet.
When we bump the version in the code, we can change this in the action interface.
cYKatherine
force-pushed
the
kcc-UID2-2329-add-dotnet-pipeline
branch
from
f2c7a4b to
3b7edc4
Compare
Please review in order of:
Successful run: https://github.com/IABTechLab/uid2-client-net/actions/runs/8197144982/job/22418640152