Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Addition of "AlphaLP" as a new term - refinements and suggestions welcome #367

Merged
merged 9 commits into from
Jan 28, 2025

Conversation

sierra-moxon
Copy link
Contributor

@sierra-moxon sierra-moxon commented Jan 28, 2025

Please see: #366 for more details.

I used the script in this repository, find_next_available_number.py to find the biggest gap in the identifier space, and picked the next from that gap:

Found gap of size 2996566: ('MS', 1003434) to ('MS', 3999999)

…S identifier and added name, synonyms and definition to the term alphaLP
…S identifier and added name, synonyms and definition to the term alphaLP
…S identifier and added name, synonyms and definition to the term alphaLP
@mobiusklein
Copy link
Contributor

Thank you for preparing the term.

For proteases, we usually associate the term itself with a regular expression describing how the protease cleaves an amino acid sequence. Is this a correct translation of your description?

/(?<=[TSAV])/

@sierra-moxon
Copy link
Contributor Author

yes, thank you - would I generate another term and add it as a regex via the "relationship" metadata?

@mobiusklein
Copy link
Contributor

Yes, please.

@mobiusklein
Copy link
Contributor

Okay, this looks ready to go. Are there any final changes you want to make before we merge this?

@sierra-moxon
Copy link
Contributor Author

no - thank you for the quick review!

@mobiusklein mobiusklein added this pull request to the merge queue Jan 28, 2025
Merged via the queue into HUPO-PSI:master with commit 91d9f47 Jan 28, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants