-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
do we want to add "neutral"? #336
Conversation
This has been proposed by the reviewer of the mzSpecLib manuscript. Do we want to make this change? What implications are there for downstream tools and files?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would support this change if it doesn't break anything. The definition is clear enough but people may not bother to look at the definition. Better to be clear since the adduct ion mass (the "M+H" mass) is sometimes also called the "theoretical mass" in the context of MS.
If we add it as a synonym instead of just changing the name, it makes the meaning clear without breaking old software that uses the "theoretical mass" name. But just renaming isn't that big a deal either; it's less impactful than obsoleting a term and replacing it with a new one. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@chambm So you would swap the changed name and the synonym around compared to the current proposal? Either seem fine to me, and as Henry said, not a bad thing for avoiding confusion.
I agree with using a synonym. As mentioned, the important thing is not to break existing software. |
Yes, I think swapping the name is fine and put the old name as a synonym. |
This has been proposed by the reviewer of the mzSpecLib manuscript. Do we want to make this change? What implications are there for downstream tools and files?