Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

do we want to add "neutral"? #336

Merged
merged 3 commits into from
Oct 4, 2024
Merged

Conversation

edeutsch
Copy link
Contributor

This has been proposed by the reviewer of the mzSpecLib manuscript. Do we want to make this change? What implications are there for downstream tools and files?

This has been proposed by the reviewer of the mzSpecLib manuscript. Do we want to make this change? What implications are there for downstream tools and files?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would support this change if it doesn't break anything. The definition is clear enough but people may not bother to look at the definition. Better to be clear since the adduct ion mass (the "M+H" mass) is sometimes also called the "theoretical mass" in the context of MS.

@chambm
Copy link
Contributor

chambm commented Sep 27, 2024

If we add it as a synonym instead of just changing the name, it makes the meaning clear without breaking old software that uses the "theoretical mass" name. But just renaming isn't that big a deal either; it's less impactful than obsoleting a term and replacing it with a new one.

Copy link
Contributor

@bittremieux bittremieux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@chambm So you would swap the changed name and the synonym around compared to the current proposal? Either seem fine to me, and as Henry said, not a bad thing for avoiding confusion.

@javizca
Copy link

javizca commented Sep 29, 2024

I agree with using a synonym. As mentioned, the important thing is not to break existing software.

@chambm
Copy link
Contributor

chambm commented Sep 30, 2024

Yes, I think swapping the name is fine and put the old name as a synonym.

@mobiusklein mobiusklein added this pull request to the merge queue Oct 4, 2024
Merged via the queue into master with commit 76b91e5 Oct 4, 2024
3 checks passed
@bittremieux bittremieux deleted the edeutsch-theo-neutral-mass branch January 17, 2025 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants