Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

JSON mode support for ollama and openai gpt #353

Merged
merged 3 commits into from
Dec 2, 2024
Merged

JSON mode support for ollama and openai gpt #353

merged 3 commits into from
Dec 2, 2024

Conversation

b10902118
Copy link
Contributor

@b10902118 b10902118 commented Nov 29, 2024 •
edited
Loading

#287

  • Added keyword_extraction=False to all *_complete functions. If True, each function handles its own JSON mode logic.
  • Moved locate_json_string_body_from_string to *_complete functions as the default JSON logic for keyword_extraction.

@b10902118
Copy link
Contributor Author

Fixed and checked in my fork's workflow. Sorry new to the process.

@LarFii
Copy link
Collaborator

LarFii commented Dec 2, 2024

Thanks for your contribution!

@LarFii LarFii merged commit 7b76382 into HKUDS:main Dec 2, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@b10902118 @LarFii