Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved naming 2 - Graphics #597

Merged
merged 8 commits into from
Jan 23, 2025

Remove randomness from FishingTest

0dcb897
Select commit
Loading
Failed to load commit list.
Merged

Improved naming 2 - Graphics #597

Remove randomness from FishingTest
0dcb897
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Jan 23, 2025 in 1s

34.86% (+0.07%) compared to c194e0f

View this Pull Request on Codecov

34.86% (+0.07%) compared to c194e0f

Details

Codecov Report

Attention: Patch coverage is 12.88344% with 142 lines in your changes missing coverage. Please review.

Project coverage is 34.86%. Comparing base (c194e0f) to head (0dcb897).

Files with missing lines Patch % Lines
.../gregs/voidps/engine/entity/character/Character.kt 0.00% 33 Missing ⚠️
...dps/world/command/debug/PlayerUpdatingCommands.kts 0.00% 11 Missing ⚠️
...orld/interact/entity/player/display/tab/Emotes.kts 0.00% 11 Missing ⚠️
.../interact/entity/player/display/tab/ItemEmotes.kts 0.00% 9 Missing ⚠️
...rld/interact/entity/player/combat/range/Ranged.kts 0.00% 2 Missing and 1 partial ⚠️
...act/entity/player/combat/range/special/DarkBow.kts 0.00% 3 Missing ⚠️
...t/entity/player/combat/range/weapon/HandCannon.kts 0.00% 3 Missing ⚠️
...ld/gregs/voidps/world/map/falador/DressingRoom.kts 0.00% 3 Missing ⚠️
...d/activity/transport/teleport/JewelleryTeleport.kt 0.00% 2 Missing ⚠️
...voidps/world/interact/entity/death/PlayerDeath.kts 0.00% 2 Missing ⚠️
... and 52 more
Additional details and impacted files
Files with missing lines Coverage Δ
...ld/gregs/voidps/engine/entity/character/Visuals.kt 14.01% <ø> (+3.52%) ⬆️
...s/world/activity/skill/runecrafting/EssenceMine.kt 85.00% <100.00%> (ø)
...world/activity/skill/runecrafting/Runecrafting.kts 67.85% <100.00%> (ø)
...world/activity/transport/teleport/HomeTeleport.kts 62.06% <100.00%> (ø)
...gs/voidps/world/community/assist/RequestAssist.kts 65.17% <100.00%> (ø)
.../gregs/voidps/world/interact/entity/effect/Stun.kt 52.94% <100.00%> (ø)
.../entity/player/combat/armour/barrows/AhrimsSet.kts 68.00% <100.00%> (ø)
...entity/player/combat/armour/barrows/GuthansSet.kts 66.66% <100.00%> (ø)
.../entity/player/combat/armour/barrows/KarilsSet.kts 63.63% <100.00%> (ø)
.../entity/player/combat/armour/barrows/ToragsSet.kts 65.21% <100.00%> (ø)
... and 69 more

... and 9 files with indirect coverage changes

@@             Coverage Diff              @@
##               main     #597      +/-   ##
============================================
+ Coverage     34.78%   34.86%   +0.07%     
- Complexity     4854     4885      +31     
============================================
  Files          1339     1339              
  Lines         47123    47121       -2     
  Branches       9516     9513       -3     
============================================
+ Hits          16393    16429      +36     
+ Misses        27348    27305      -43     
- Partials       3382     3387       +5
Components Coverage Δ
Content 28.59% <15.50%> (-0.02%) ⬇️
Engine 43.34% <0.00%> (+0.04%) ⬆️
Network 71.85% <ø> (ø)
View more details on Codecov