Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved naming 2 - Graphics #597

Merged
merged 8 commits into from
Jan 23, 2025
Merged

Improved naming 2 - Graphics #597

merged 8 commits into from
Jan 23, 2025

Conversation

GregHib
Copy link
Owner

@GregHib GregHib commented Jan 23, 2025

  • Add delta invert function
  • Add more tests to Delta
  • Simplify exactMove calls
  • Move set and clear graphic to Character
  • Rename graphic helpers to gfx

Copy link

github-actions bot commented Jan 23, 2025

Qodana Community for JVM

It seems all right 👌

No new problems were found according to the checks applied

💡 Qodana analysis was run in the pull request mode: only the changed files were checked
☁️ View the detailed Qodana report

Contact Qodana team

Contact us at [email protected]

Copy link

codecov bot commented Jan 23, 2025

Codecov Report

Attention: Patch coverage is 12.88344% with 142 lines in your changes missing coverage. Please review.

Project coverage is 34.86%. Comparing base (c194e0f) to head (0dcb897).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
.../gregs/voidps/engine/entity/character/Character.kt 0.00% 33 Missing ⚠️
...dps/world/command/debug/PlayerUpdatingCommands.kts 0.00% 11 Missing ⚠️
...orld/interact/entity/player/display/tab/Emotes.kts 0.00% 11 Missing ⚠️
.../interact/entity/player/display/tab/ItemEmotes.kts 0.00% 9 Missing ⚠️
...rld/interact/entity/player/combat/range/Ranged.kts 0.00% 2 Missing and 1 partial ⚠️
...act/entity/player/combat/range/special/DarkBow.kts 0.00% 3 Missing ⚠️
...t/entity/player/combat/range/weapon/HandCannon.kts 0.00% 3 Missing ⚠️
...ld/gregs/voidps/world/map/falador/DressingRoom.kts 0.00% 3 Missing ⚠️
...d/activity/transport/teleport/JewelleryTeleport.kt 0.00% 2 Missing ⚠️
...voidps/world/interact/entity/death/PlayerDeath.kts 0.00% 2 Missing ⚠️
... and 52 more
Additional details and impacted files
Files with missing lines Coverage Δ
...ld/gregs/voidps/engine/entity/character/Visuals.kt 14.01% <ø> (+3.52%) ⬆️
...s/world/activity/skill/runecrafting/EssenceMine.kt 85.00% <100.00%> (ø)
...world/activity/skill/runecrafting/Runecrafting.kts 67.85% <100.00%> (ø)
...world/activity/transport/teleport/HomeTeleport.kts 62.06% <100.00%> (ø)
...gs/voidps/world/community/assist/RequestAssist.kts 65.17% <100.00%> (ø)
.../gregs/voidps/world/interact/entity/effect/Stun.kt 52.94% <100.00%> (ø)
.../entity/player/combat/armour/barrows/AhrimsSet.kts 68.00% <100.00%> (ø)
...entity/player/combat/armour/barrows/GuthansSet.kts 66.66% <100.00%> (ø)
.../entity/player/combat/armour/barrows/KarilsSet.kts 63.63% <100.00%> (ø)
.../entity/player/combat/armour/barrows/ToragsSet.kts 65.21% <100.00%> (ø)
... and 69 more

... and 9 files with indirect coverage changes

@@             Coverage Diff              @@
##               main     #597      +/-   ##
============================================
+ Coverage     34.78%   34.86%   +0.07%     
- Complexity     4854     4885      +31     
============================================
  Files          1339     1339              
  Lines         47123    47121       -2     
  Branches       9516     9513       -3     
============================================
+ Hits          16393    16429      +36     
+ Misses        27348    27305      -43     
- Partials       3382     3387       +5     
Components Coverage Δ
Content 28.59% <15.50%> (-0.02%) ⬇️
Engine 43.34% <0.00%> (+0.04%) ⬆️
Network 71.85% <ø> (ø)

@GregHib GregHib merged commit dac95ac into main Jan 23, 2025
5 checks passed
@GregHib GregHib deleted the improved-gfx-naming branch January 23, 2025 12:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant