-
-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Solana to my projects #3533
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
# Conflicts: # src/components/modals/ManageProjectAddresses/AddNewAddress.tsx # src/components/modals/ManageProjectAddresses/ManageProjectAddressesModal.tsx # src/components/modals/ManageProjectAddresses/NetworkWalletAddress.tsx # src/lib/helpers.ts
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @RamRamez
I just added some comments for improvement of codes, other parts seem good
src/components/modals/ManageProjectAddresses/ManageProjectAddressesModal.tsx
Show resolved
Hide resolved
src/components/modals/ManageProjectAddresses/ManageProjectAddressesModal.tsx
Show resolved
Hide resolved
# Conflicts: # src/components/modals/ManageProjectAddresses/AddNewAddress.tsx
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Had answered yesterday here
#3533 (comment)
@MohammadPCh @mohammadranjbarz Can you please review this PR? it's ready. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @RamRamez Sorry for late review
src/components/modals/ManageProjectAddresses/ManageProjectAddressesModal.tsx
Show resolved
Hide resolved
# Conflicts: # pages/test2.tsx # src/components/modals/ManageProjectAddresses/AddNewAddress.tsx # src/hooks/useAuthenticationWallet.ts # src/lib/helpers.ts
I resolved the conflicts. |
Thanks @RamRamez |
So can we a assume it's done? |
#3393
This PR is ready for review. I will keep this draft until PR #3523 is merged.