As a Project Owner, I want to add a Solana address to receive donations to

[divine-comedian]

A Project Owner should be able to simply add a solana address to their project page that defines the recipient address of donations made on Solana
Should consider any changes in #3078

[MoeNick]

For adding the Addresses on the front end we have 2 views that should work:

• My projects, manage addresses, add address
• Add / Edit project view.

[aminlatifi]

@RamRamez To add a Solana address to a project note these:

• NetworkId: 0,
• ChainType: SOLANA
• Address capitalization must be preserved

[RamRamez]

@aminlatifi This error is coming from "walletAddressIsValid" endpoint. I suggest replacing "Eth address" with "Address" to contain Solana addresses as well.

[aminlatifi]

@aminlatifi This error is coming from "walletAddressIsValid" endpoint. I suggest replacing "Eth address" with "Address" to contain Solana addresses as well.

Which mutation are you calling? with which parameters?

[RamRamez]

@aminlatifi This error is coming from "walletAddressIsValid" endpoint. I suggest replacing "Eth address" with "Address" to contain Solana addresses as well.

I already sent the mutation here. If you call this endpoint and query a wallet address that is already being used for a project, you will see that error.

[aminlatifi]

@aminlatifi This error is coming from "walletAddressIsValid" endpoint. I suggest replacing "Eth address" with "Address" to contain Solana addresses as well.

I already sent the mutation here. If you call this endpoint and query a wallet address that is already being used for a project, you will see that error.

I tested the endpoint with some random address, it works fine

curl --location 'https://impact-graph.serve.giveth.io/graphql' \
--header 'Content-Type: application/json' \
--data '{"query":"# Write your query or mutation here\nquery {\n  walletAddressIsValid(address:\"2axeaEqsJe9HPrK8QZWD2y9Y3zzdRRQXd9q5qVuuM3Pt\") \n}","variables":{}}'

[MoeNick]

@RamRamez can we make it today?

[RamRamez]

@RamRamez can we make it today?

I even worked on it on my weekend (Friday and Saturday) and sent a draft PR.
Adding Solana to create project page is done. I created some projects with Solana address and it's working well.
But we have some typescript problems and some other issues like adding network config.
I'm trying to finalize it today.

[MoeNick]

Great, Thanks @RamRamez

[RamRamez]

I can't submit Solana addresses with "updateProjectVerificationForm" endpoint. @aminlatifi Please check it.

[RamRamez]

I sent the PR.
Create project page, manage funds in verification modal and donations tab in project view, is done.
Tomorrow I will work on Manage addresses in user dashboard (My projects).

[aminlatifi]

I can't submit Solana addresses with "updateProjectVerificationForm" endpoint. @aminlatifi Please check it.

It will be fixed by Giveth/impact-graph#1210

[RamRamez]

Adding Solana to managing addresses in My projects in done. I think we need to update backend as well.
When I try to add Solana address with "addRecipientAddressToProject" I get this error.
@aminlatifi can you check please:

[MoeNick]

Adding Solana to managing addresses in My projects in done. I think we need to update backend as well. When I try to add Solana address with "addRecipientAddressToProject" I get this error. @aminlatifi can you check please:

@CarlosQ96 can you take a look, please?

[MoeNick]

@mohammadranjbarz is on it :))

[mohammadranjbarz]

@RamRamez Do you send chainType in this query?
If you want to add solana address you should send it chainType:'SOLANA'

[RamRamez]

@RamRamez Do you send chainType in this query? I you want to add solana address you should send it chainType:'SOLANA'

Yes, I'm sending it.

[mohammadranjbarz]

@RamRamez Can you change this line

giveth-dapps-v2/src/apollo/gql/gqlProjects.ts

Line 447 in 2d9e499

mutation ($projectId: Float!, $networkId: Float!, $address: String!) {

and replace $address: String! with $address: ChainType! and test it again?

[RamRamez]

Thanks @mohammadranjbarz , it's fixed

[maryjaf]

1-
please take a look on this error in create project page @RamRamez

[maryjaf]

2-
In edit page, when I set an ETH address in solane address, no error message is shown in below modal
and when I tap on publish I get an error

[maryjaf]

1- please take a look on this error in create project page @RamRamez

I haven't seen this error again, maybe it's about my connection

and item 2 have been resolved

[RamRamez]

Thanks @maryjaf, I tested these two issues with different browsers and couldn't reproduce the bugs either.

[maryjaf]

• Add solana in create project page-- Test is passed
• Add solana in edit project page -- Test is passed
• add solana in manage address modal (my project list) -- Waiting for Code Review

[MoeNick]

This issue is still in code review, shall I put it in QA?

[maryjaf]

• Add solana in create project page-- Test is passed
• Add solana in edit project page -- Test is passed
• add solana in manage address modal (my project list) -- Waiting for Code Review

it is the last status

[MoeNick]

@jainkrati
You wil talk with team to resolve this problem

[maryjaf]

[ ] add solana in manage address modal (my project list) -- Waiting for Code Review

Is this still in code review state?

[maryjaf]

I'm not sure this bug be related to incomplete implementation of this part or not however I describe this to be checked.
When My project has a solana recipient address, by tapping on manage address and select a chain this address is shown in Eth chain by default
I think it's better if a project doesn't have an eth address the default value of address won't be set
@RamRamez

Screen.Recording.2024-01-08.at.3.12.52.PM.mov

[MoeNick]

Good catch @maryjaf

[RamRamez]

@maryjaf I've fixed it PR #3533 (without recurring donations enabled)

[MoeNick]

@maryjaf to QA add solana in manage address modal (my project list) again please

[maryjaf]

last changes aren't on stg, maybe it hasn't been reviewed yet.

[aminlatifi]

@maryjaf @MoeNick The PR is merged.

[maryjaf]

Screen.Recording.2024-01-09.at.2.35.15.PM.mov

The user has a same address on one or more ETH chain and one address on solana , in this situation by tapping on other eth chain the default address isn't set, is it accepted? @MoeNick
or current address that it is set on ETH chain should be shown ?

[MoeNick]

If user has set an eth address before and want to set another eth, we should suggest the same eth address to user.

This was according to @GriffGreen requirement once and we applied it.
I think @MohammadPCh was implemented that.

But however if it's too complicated to implement, I think its fine.

[aminlatifi]

If user has set and eth address before and want to set another eth, we should suggest the same eth address to user.

This was according to @GriffGreen requirement once and we applied it. I think @MohammadPCh was implemented that.

But however if it's too complicated to implement, I think its fine.

@RamRamez has refactored that part. Ramin, can you look at this issue?

[RamRamez]

In PR #3605, I excluded non EVM chains. So, we won't suggest anything for non EVM chains and will only have address suggestion for ETH addresses

[MoeNick]

Screen.Recording.2024-01-09.at.2.35.15.PM.mov

The user has a same address on one or more ETH chain and one address on solana , in this situation by tapping on other eth chain the default address isn't set, is it accepted? @MoeNick

or current address that it is set on ETH chain should be shown ?

@RamRamez so in this case, user get some suggestions for eth addresses?

[RamRamez]

@MoeNick Yes, we should suggest

[maryjaf]

Plz check this @RamRamez
when my user has a solana address and one address on eth chain, the default address won't be set correctly for other eth chains and solana address be shown

Screen.Recording.2024-01-11.at.1.22.56.PM.mov

[maryjaf]

when my user has a solana address and one address on eth chain, the default address won't be set correctly for other eth chains and solana address be shown

Thanks @RamRamez this problem has been resolved