SmartPay Website Release changes v2.0 #380
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Documentation and Code Review
Updating intro text to meet USWDS suggestion.
Update intro text to meet USWDS guidance.
Shorten intro to align with USWDS guidance.
Update card/account holder language.
Updated goods/services language.
Update intro text.
Update/streamline content.
Add intro.
Add an intro.
Add an intro.
Add intro to this page.
Update Program to program per Style Guide.
Updated intro and card/account language per the Style Guide.
Updating the intro and card/account references per the Style Guide.
Update intro.
Update intro.
Intro update.
Added an intro.
Update intro text.
Update content flow.
Update card/account per Style Guide.
Updated intro.
Updated to reflect card/account holder per the Style Guide.
Updated intro.
Update intro.
Update intro.
Update intro.
Update intro.
…ent-solution.pdf Delete file.
Update intro.
Update content to match with the Style Guide.
Updated employee information.
Update formatting issue.
Update integrated information.
Updated integrated information.
Updated IBAs to IBA.
Updated formatting issue.
Updating format issue.
Rebekah112923v2
Includes (Sprint 19 and 20 stories): Issue 370 USWDS update from 3.5 to 3.6.1 Issue 373 FASCSA Exclusion Link and Language Content changes
mark-meyer
reviewed
Nov 30, 2023
| @@ -1,6 +1,6 @@ | |||
| --- | |||
| title: About GSA SmartPay® | |||
| description: "The GSA SmartPay program is the world’s largest government charge card and commercial payment solutions program." | |||
There was a problem hiding this comment.
I think deleting the description in this metadata will result in an empty <meta name="description"> tag on the /about/ page. This looks like it's not intentional.
There was a problem hiding this comment.
The description has been added back. Removed by mistake.
| The federal government issued an [interim rule](https://www.federalregister.gov/documents/2023/10/05/2023-21320/federal-acquisition-regulation-implementation-of-federal-acquisition-supply-chain-security-act) that amends the Federal Acquisition Regulation (FAR) to implement supply chain risk information sharing and FASCSA orders. This rule became effective on December 4, 2023. | ||
|
|
||
| ## Accessing FASCSA Orders | ||
| [The System for Award Management (SAM)](http://sam.gov) is an official website of the U.S. Government that helps users navigate the federal award lifecycle. |
There was a problem hiding this comment.
This is minor and doesn't have much effect on end users, but I wonder if we should make the link to https://.... to avoid making the browser redirect from http to https (same comment of the other link below).
There was a problem hiding this comment.
Updated links to include https instead of http.
src/content/about/statistics.md
Outdated
| - [Sales, Transactions, and Account Holder Data (FY 2009–September 2022) [XLSX, 7MB]](/files/stats-tool.xlsx) – Spreadsheets containing current statistics for GSA SmartPay Purchase, Travel and Fleet. Note: For questions about usage of the tool and underlying data, refer to the [Frequently Asked Questions](/faq) page. | ||
| - [Fiscal Years 1999–2009 Card Sales, Transactions and Account Holder Data [XLS, 10.2 MB]](/files/fy99-09-card-sales-transactions-cardholder-data.xls) – Spreadsheets containing fiscal years 1999–2009 data and statistics for GSA SmartPay Purchase, Travel and Fleet. | ||
| - [Sales, Transactions, and Card/Account Holder Data (FY 2009–July 2023) [XLSX, 8MB]](/files/stats-tool.xlsx) – Spreadsheets containing current statistics for GSA SmartPay Purchase, Travel and Fleet business lines. Note: For questions about usage of the tool and underlying data, refer to the [Frequently Asked Questions](/faq) page. | ||
| - [Fiscal Years 1999–2009 Card Sales, Transactions and Card/Account Holder Data [XLS, 10.2 MB]](/files/fy99-09-card-sales-transactions-cardholder-data.xls) – Spreadsheets containing fiscal years 1999–2009 data and statistics for GSA SmartPay Purchase, Travel and Fleet business lines. |
There was a problem hiding this comment.
A little outside my swim lane, but it looks like other place on the site are using the Oxford comma. Should this be GSA SmartPay Purchase, Travel, and Fleet business lines. with the comma after Travel?
There was a problem hiding this comment.
Great catch! Added missing commas in the file.
Addressed Code Review comments for Production Release
Addressed code review comments.
mark-meyer
approved these changes
Nov 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Includes (Sprint 19 and 20 stories):
Issue 370 USWDS update from 3.5 to 3.6.1
Issue 373 FASCSA Exclusion Link and Language
Content changes