Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[#25,#5, #27] Header / Nav / Banner / Utility Menu #124
[#25,#5, #27] Header / Nav / Banner / Utility Menu #124
Changes from 22 commits
8c1faf3
65e05eb
9e3f4d7
6b758b0
7c1e8be
589baf3
f2e0424
4e770a9
b618daa
8e9a0c4
6b50585
79f8309
28a6fe7
532e88e
1c8ffda
ebd7921
2f168d3
0833135
3312eef
6fc45ac
9e45fe9
1bcf5d9
824a4bc
91b5739
52454b5
19f2579
147fccb
3532264
6173cec
b1301c6
acbed7e
0138b5f
06f1b32
c7693cd
c7387b2
e99eace
43f5037
b3b6772
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added some more responsive styles (1bcf5d9) to this helper function and removed the extra partial template. IMO it's okay to embed smaller html tags directly in the helper.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is the broken tag newline intentional? I see it in a few places and it looks odd to me
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was able to refactor this so it didn't need separate sections for mobile and desktop, using the 'mobile-first' philosophy and altering the sizes for
desktop:
. You can see what I changed here - (1bcf5d9).