[#25,#5, #27] Header / Nav / Banner / Utility Menu #124
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stonefilipczak
changed the title
stepchud
reviewed
Aug 20, 2024
stepchud
requested changes
Aug 22, 2024
Co-authored-by: Stephen Chudleigh <[email protected]>
remove unused partial template
stepchud
force-pushed
the
25_eval_header
branch
from
4ad351f to
1bcf5d9
Compare
stepchud
reviewed
Aug 27, 2024
| # frozen_string_literal: true | ||
|
|
||
| module NavigationHelper | ||
| def utility_menu_link(image_path, href, alt, button_label) |
There was a problem hiding this comment.
I added some more responsive styles (1bcf5d9) to this helper function and removed the extra partial template. IMO it's okay to embed smaller html tags directly in the helper.
| @@ -0,0 +1,22 @@ | |||
| <!-- Utility Menu --> | |||
There was a problem hiding this comment.
I was able to refactor this so it didn't need separate sections for mobile and desktop, using the 'mobile-first' philosophy and altering the sizes for desktop:. You can see what I changed here - (1bcf5d9).
There was a problem hiding this comment.
these partials aren't needed anymore
stepchud
reviewed
Sep 3, 2024
Comment on lines
+99
to
+100
| <em class="usa-logo__text" | ||
| ><a href="/" title="challenge.gov"> |
There was a problem hiding this comment.
is the broken tag newline intentional? I see it in a few places and it looks odd to me
Suggested change
| <em class="usa-logo__text" | |
| ><a href="/" title="challenge.gov"> | |
| <em class="usa-logo__text"> | |
| <a href="/" title="challenge.gov"> |
stepchud
approved these changes
Sep 3, 2024
cpreisinger
added a commit
that referenced
this pull request
Sep 4, 2024
…d-rails-phoenix-session * 'dev' of github.com:GSA/Challenge_platform: (21 commits) [#25,#5, #27] Header / Nav / Banner / Utility Menu (#124) Adjust puma config Manifest and config tweak Config tweaks adjust asset precompile Configure default proxy if env set Adjust ports Memory tweaks env tweaks Memory tweak More memory Adjust sidecar boot Move proxy into its own manifest Add local proxy sidecar 34 Use skip before action instead of except for timeout 34 Readability fix for check_session_expiration 34 Fix for timeout not redirecting properly 34 Remove session timeout from .envrc 34 Change session timeout env var to a constant 34 Fix failing session timeout test ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR for header / nav / banner / utility menu
GH issues #25,#5, #27
Logged in:
Logged out: